bugfix: do not fill 0 buffer, and skip validate features #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Buffer reset to 0 will cause race during concurrency. 2. Previously, the second validate_header did not actually take effect. Now it is repaired, and it is found that the features of blob info do not set the --inline-bootstrap position to true, so the check of features is temporarily skipped. Essentially needs to be fixed from nydus-image from upstream. Signed-off-by: zhaoshang <[email protected]> Signed-off-by: zyfjeff <[email protected]>
zyfjeff
requested review from
imeoer,
luodw and
changweige
and removed request for
a team
|
@zyfjeff , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/90731 |
Codecov Report
@@ Coverage Diff @@
## master #1412 +/- ##
==========================================
- Coverage 46.45% 46.44% -0.02%
==========================================
Files 123 123
Lines 38602 38602
Branches 38602 38602
==========================================
- Hits 17931 17927 -4
- Misses 19702 19703 +1
- Partials 969 972 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer reset to 0 will cause race during concurrency.
Previously, the second validate_header did not actually take effect. Now it is repaired, and it is found that the features of blob info do not set the --inline-bootstrap position to true, so the check of features is temporarily skipped. Essentially needs to be fixed from nydus-image from upstream.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.