nydusify: fix copy race issue #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
requested review from
jiangliu,
gaius-qi and
hsiangkao
and removed request for
a team
1. Fix lost namespace on containerd image pull context: ``` pull source image: namespace is required: failed precondition ``` 2. Fix possible semaphore Acquire race on the same one context: ``` panic: semaphore: released more than held ``` Signed-off-by: Yan Song <[email protected]>
imeoer
force-pushed
the
fix-nydusify-copy-sem
branch
from
77d8913
to
ef13fd4
Compare
imeoer
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1465 +/- ##
==========================================
- Coverage 44.37% 44.37% -0.01%
==========================================
Files 123 123
Lines 38896 38896
Branches 38896 38896
==========================================
- Hits 17261 17259 -2
- Misses 20695 20696 +1
- Partials 940 941 +1 |
imeoer
force-pushed
the
fix-nydusify-copy-sem
branch
from
ef13fd4
to
bd61947
Compare
imeoer
changed the title
Signed-off-by: Yan Song <[email protected]>
imeoer
force-pushed
the
fix-nydusify-copy-sem
branch
from
bd61947
to
0be3538
Compare
imeoer
changed the title
bergwolf
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
The bug is introduced from #1446.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.