fix up build on macos #1477
Merged
fix up build on macos #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergwolf
requested review from
liubin,
liubogithub and
gaius-qi
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #1477 +/- ##
=======================================
Coverage 62.49% 62.49%
=======================================
Files 123 123
Lines 43132 43131 -1
Branches 43132 43131 -1
=======================================
Hits 26955 26955
+ Misses 14869 14868 -1
Partials 1308 1308
|
Signed-off-by: Peng Tao <[email protected]>
We are only testing blob cache and fscache in unit tests. And we are testing linux device id. All of them do not work on macos at all. Signed-off-by: Peng Tao <[email protected]>
These are u16 on macos. Signed-off-by: Peng Tao <[email protected]>
bergwolf
force-pushed
the
github/macos
branch
from
340fd4d
to
20f803e
Compare
jiangliu
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix failures in https://github.com/dragonflyoss/nydus/actions/runs/6804602738, and add smoke test to validate macos build.