nydusify: support --push-chunk-size option #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
requested review from
liubogithub,
luodw and
gaius-qi
and removed request for
a team
Desiki-high
reviewed
Nov 21, 2023
imeoer
force-pushed
the
nydusify-copy-chunked-push
branch
from
08c4f07
to
845a72d
Compare
6 tasks
imeoer
force-pushed
the
nydusify-copy-chunked-push
branch
2 times, most recently
from
fb3463a
to
91ff321
Compare
Reference: containerd/containerd#9405 Will replace containerd dep to upstream version if the PR can be merged. Signed-off-by: Yan Song <[email protected]>
Fix the lint check error by updating containerd package:
```
golangci-lint run
Error: commands/rpull.go:89:2: SA1019: log.G is deprecated: use [log.G]. (staticcheck)
log.G(pCtx).WithField("image", ref).Debug("fetching")
^
```
Signed-off-by: Yan Song <[email protected]>
imeoer
force-pushed
the
nydusify-copy-chunked-push
branch
from
d1c9cd0
to
eec3f4d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1490 +/- ##
==========================================
- Coverage 62.51% 62.51% -0.01%
==========================================
Files 123 123
Lines 43148 43148
Branches 43148 43148
==========================================
- Hits 26975 26973 -2
Misses 14870 14870
- Partials 1303 1305 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: containerd/containerd#9405
Will replace containerd dep to upstream version if the PR can be merged.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.