Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoke: add benchmark test #1497

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Conversation

Desiki-high
Copy link
Member

Relevant Issue (if applicable)

Part of #1460.

Details

  1. Refactor performance_test, and move clearContainer to tests/tools.
  2. Add benchmark test, benchmark test will dump the metrics to a JSON file.
  3. Use the Golang version benchmark in Benchmark to replace the Python version benchmark.
  4. Delete the Python version benchmark.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

1. refactor performance_test, move clearContainer to tools.
2. add benchmark test.
benchmark test will test image container, and save metrics to json file.
Fox example
```json
{
	e2e_time: 2747131
	image_size: 2107412
	read_amount: 121345
	read_count: 121
}
```

Signed-off-by: Yadong Ding <[email protected]>
@Desiki-high Desiki-high requested review from a team as code owners November 30, 2023 02:22
@Desiki-high Desiki-high requested review from liubin, jiangliu and hsiangkao and removed request for a team November 30, 2023 02:22
We should deprecate python version benchmark.

Signed-off-by: Yadong Ding <[email protected]>
@Desiki-high
Copy link
Member Author

I will support more images and more features in the next PRs.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #1497 (764265b) into master (8ad7ae5) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1497      +/-   ##
==========================================
- Coverage   62.75%   62.72%   -0.04%     
==========================================
  Files         123      123              
  Lines       43340    43340              
  Branches    43340    43340              
==========================================
- Hits        27199    27183      -16     
- Misses      14827    14842      +15     
- Partials     1314     1315       +1     

see 5 files with indirect coverage changes

@jiangliu jiangliu merged commit f5001bb into dragonflyoss:master Nov 30, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants