Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoke: support node image #1500

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

Desiki-high
Copy link
Member

Relevant Issue (if applicable)

Part of #1460.

Details

Add test for node:19.8 in benchmark.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

smoke/tests/tool/container.go Outdated Show resolved Hide resolved
smoke/tests/tool/container.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #1500 (a3f5ce8) into master (e0fc6a1) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1500      +/-   ##
==========================================
- Coverage   62.76%   62.74%   -0.02%     
==========================================
  Files         123      123              
  Lines       43340    43340              
  Branches    43340    43340              
==========================================
- Hits        27201    27195       -6     
- Misses      14827    14831       +4     
- Partials     1312     1314       +2     

see 2 files with indirect coverage changes

@Desiki-high
Copy link
Member Author

The nydus-integration-test error always happens, I think it is not caused by this pr. cc @imeoer

@imeoer imeoer merged commit 3f999a7 into dragonflyoss:master Dec 1, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants