Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bats test: move the logic of generating dockerfile into common lib #1516

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

yqleng1987
Copy link
Contributor

@yqleng1987 yqleng1987 commented Dec 13, 2023

Passed in local machine
image

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@yqleng1987 yqleng1987 requested a review from a team as a code owner December 13, 2023 06:53
@yqleng1987 yqleng1987 requested review from jiangliu, adamqqqplay and Desiki-high and removed request for a team December 13, 2023 06:53
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #1516 (29925bf) into master (55a999b) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
+ Coverage   62.72%   62.73%   +0.01%     
==========================================
  Files         129      129              
  Lines       44158    44158              
  Branches    44158    44158              
==========================================
+ Hits        27697    27702       +5     
+ Misses      15092    15088       -4     
+ Partials     1369     1368       -1     

see 3 files with indirect coverage changes

Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adamqqqplay adamqqqplay merged commit 45331d5 into dragonflyoss:master Dec 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants