Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nydusify: upgrade acceleration-service v0.2.14 #1584

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Jun 5, 2024

To bring the fixup: goharbor/acceleration-service#290

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@imeoer imeoer requested a review from a team as a code owner June 5, 2024 07:38
@imeoer imeoer requested review from jiangliu, ccx1024cc and changweige and removed request for a team June 5, 2024 07:38
Copy link
Member

@Desiki-high Desiki-high left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.52%. Comparing base (79a7015) to head (1852234).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1584   +/-   ##
=======================================
  Coverage   61.51%   61.52%           
=======================================
  Files         144      144           
  Lines       46616    46616           
  Branches    44602    44602           
=======================================
+ Hits        28676    28680    +4     
+ Misses      16456    16452    -4     
  Partials     1484     1484           

see 2 files with indirect coverage changes

@imeoer imeoer merged commit de7cfc4 into dragonflyoss:master Jun 6, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants