a series of fixups for nydusd #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
requested review from
jiangliu,
ccx1024cc and
Desiki-high
and removed request for
a team
imeoer
changed the title
added 3 commits
June 18, 2024 02:04
1. Case1: Fuse server exits in thread not main. There is possibility
that process finishes before shutdown of server.
2. Case2: Fuse server exits in thread of state machine. There is
possibiltiy that state machine not responses to signal catch
thread. Then dead lock happens. Process exits before shutdown of
server.
This pr aims to seperator shutdown actions from signal catch
handler. It only notifies controller. Controller exits with
shutdown of fuse server. No race. No deadlock.
Signed-off-by: 泰友 <[email protected]>
User io may involve discontinuous segments in different chunks. Bad
read is produced by merging them into continuous one. That is what
Region does. This pr separate discontinuous segments into different
regions, avoiding merging forcibly.
Signed-off-by: 泰友 <[email protected]>
There are scenes that cache file is smaller than expect size. Such as:
1. Nydusd 1.6 generates cache file by prefetch, which is smaller than size in boot.
2. Nydusd 2.2 generates cache file by prefetch, when image not provide ext blob tables.
3. Nydusd not have enough time to fill cache for blob.
Equality check for size is too much strict for both 1.6
compatibility and 2.2 concurrency. This pr ensures blob size smaller
or equal than expect size. It also truncates blob cache when smaller
than expect size.
Signed-off-by: 泰友 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1587 +/- ##
==========================================
- Coverage 61.53% 61.49% -0.05%
==========================================
Files 144 144
Lines 46616 46630 +14
Branches 44602 44616 +14
==========================================
- Hits 28685 28673 -12
- Misses 16452 16469 +17
- Partials 1479 1488 +9
|
imeoer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
FROM #1561
Just drop the commit 8df5d7f, it's breaks block device unit test, we still need to investigate.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.