support generating separate blob for prefetched files #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daiyongxuan
requested review from
jiangliu,
gaius-qi and
Desiki-high
and removed request for
a team
kevinXYin
reviewed
Oct 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1629 +/- ##
==========================================
- Coverage 60.43% 60.10% -0.33%
==========================================
Files 146 147 +1
Lines 48841 49513 +672
Branches 46322 46994 +672
==========================================
+ Hits 29517 29760 +243
- Misses 17558 17971 +413
- Partials 1766 1782 +16
|
imeoer
changed the title
imeoer
reviewed
Oct 23, 2024
imeoer
reviewed
Oct 26, 2024
smoke/tests/native_layer_test.go
Outdated
| @@ -81,6 +81,7 @@ func (n *NativeLayerTestSuite) TestMakeLayers() test.Generator { | |||
| ctx.Runtime.RafsMode = scenario.GetString(paramRafsMode) | |||
| ctx.Runtime.EnablePrefetch = scenario.GetBool(paramEnablePrefetch) | |||
| ctx.Runtime.AmplifyIO = scenario.GetUInt64(paramAmplifyIO) | |||
| ctx.Runtime.ChunkDedupDb = scenario.GetString(paramChunkDedupDb) | |||
There was a problem hiding this comment.
This seems like an unnecessary merge commit.
imeoer
reviewed
Oct 26, 2024
builder/src/chunkdict_generator.rs
Outdated
| tree: &mut Tree, | ||
| ctx: &mut BuildContext, | ||
| bootstrap_mgr: &mut BootstrapManager, | ||
| blobtable: &mut RafsV6BlobTable, |
There was a problem hiding this comment.
blob_table, and need also to be compatible with RAFS v5.
daiyongxuan
force-pushed
the
master
branch
4 times, most recently
from
7127c1e
to
a2a2478
Compare
We can statically analyze the image entrypoint dependency, or use runtime dynamic analysis technologies such as ebpf, fanotify, metric, etc. to obtain the container file access pattern, and then build this part of data into an independent image layer: * preferentially fetch blob during the image startup phase to reduce network and disk IO. * avoid frequent image builds, allows for better local cache utilization. Implement optimize subcommand to optimize image bootstrap from a prefetch file list, generate a new blob. ``` nydus-image optimize --prefetch-files /path/to/prefetch-files.txt \ --bootstrap /path/to/bootstrap \ --blob-dir /path/to/blobs ``` This will generate a new bootstrap and new blob in `blob-dir`. Signed-off-by: daiyongxuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue #1589
The objective is to create an independent image layer to prioritize the fetching of necessary blobs during startup, enhancing performance.
Details
This introduces the "optimize" subcommand, which generates a new blob containing prefetch files and creates a new RAFS format bootstrap. This ensures compatibility with the nydus-image check and optimizes the startup process.