Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stubs and mocks #18

Merged
merged 29 commits into from
Jun 24, 2020
Merged

stubs and mocks #18

merged 29 commits into from
Jun 24, 2020

Conversation

crookse
Copy link
Member

@crookse crookse commented Jun 23, 2020 •
edited
Loading

Closes #4

For those outside of the Drash Land team, if you're reading this PR, the team and I agreed on the following definitions of stubs and mocks:

table

@crookse crookse added the WIP This item is a work in progress label Jun 23, 2020
@crookse crookse removed the WIP This item is a work in progress label Jun 23, 2020
ebebbington
ebebbington approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@ebebbington ebebbington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tiniest things noted, but i'm happy with it, really good work!

README.md Outdated Show resolved Hide resolved
src/mock_builder.ts Show resolved Hide resolved
@crookse crookse changed the title Issue #4 stubs stubs and mocks Jun 24, 2020
saragee3
saragee3 reviewed Jun 24, 2020
View reviewed changes
README.md Show resolved Hide resolved
saragee3
saragee3 approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@saragee3 saragee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

Guergeiro
Guergeiro approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@Guergeiro Guergeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My charts are being used in the definition of what doubles are 😳

@crookse crookse merged commit 5e8120a into master Jun 24, 2020
@crookse crookse deleted the issue-#4-stubs branch June 24, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebebbington ebebbington ebebbington approved these changes

@Guergeiro Guergeiro Guergeiro approved these changes

@saragee3 saragee3 saragee3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stubs
4 participants
@crookse @saragee3 @Guergeiro @ebebbington