Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docs): move editor service to docs-ui #3486

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Sep 19, 2024

close https://github.com/dream-num/univer-pro/issues/2546
close https://github.com/dream-num/univer-pro/issues/2545

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 19, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  f99dc7a
info  For more information, see full report

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 1.38408% with 285 lines in your changes missing coverage. Please review.

Project coverage is 30.91%. Comparing base (4bc700b) to head (f99dc7a).
Report is 10 commits behind head on dev.

Files with missing lines Patch % Lines
packages/docs-ui/src/services/editor/editor.ts 0.00% 165 Missing ⚠️
...docs/src/services/doc-selection-manager.service.ts 0.00% 28 Missing ⚠️
...services/selection/doc-selection-render.service.ts 0.00% 26 Missing ⚠️
...s-ui/src/services/editor/editor-manager.service.ts 0.00% 20 Missing ⚠️
packages/docs-ui/src/basics/editor.ts 0.00% 14 Missing ⚠️
...es/docs-ui/src/commands/commands/delete.command.ts 0.00% 5 Missing ⚠️
...der-controllers/doc-selection-render.controller.ts 0.00% 4 Missing ⚠️
...ommands/commands/table/doc-table-delete.command.ts 0.00% 3 Missing ⚠️
...render-controllers/doc-editor-bridge.controller.ts 0.00% 3 Missing ⚠️
...ocs-ui/src/services/clipboard/clipboard.service.ts 0.00% 3 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3486      +/-   ##
==========================================
+ Coverage   30.83%   30.91%   +0.08%     
==========================================
  Files        2158     2161       +3     
  Lines      113186   113476     +290     
  Branches    24825    24885      +60     
==========================================
+ Hits        34897    35078     +181     
- Misses      78289    78398     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review September 19, 2024 12:59
@Jocs Jocs added the qa:untested This PR is ready to be tested label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant