Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DISABLE_ADMIN_PASSWORD_CHECK still show admin password modal #406

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

dreamhunter2333
Copy link
Owner

@dreamhunter2333 dreamhunter2333 commented Aug 14, 2024

User description

#390


PR Type

Bug fix, Enhancement, Documentation


Description

  • Added disableAdminPasswordCheck to the settings response in the backend.
  • Updated global state and admin page visibility logic in the frontend to consider disableAdminPasswordCheck.
  • Added error handling for missing domains in the settings response.
  • Updated several frontend and worker dependencies to their latest versions.
  • Added a new section for the upgrade process in the documentation.
  • Added a note about string format for variables in the documentation.

Changes walkthrough 📝

Relevant files
Enhancement
2 files
commom_api.ts
Add `disableAdminPasswordCheck` to settings response         

worker/src/commom_api.ts

  • Added disableAdminPasswordCheck to the settings response.
+1/-0     
index.js
Update global state and admin page visibility logic           

frontend/src/store/index.js

  • Added disableAdminPasswordCheck to global state.
  • Updated showAdminPage computed property to consider
    disableAdminPasswordCheck.
  • +6/-1     
    Bug fix
    1 files
    index.js
    Add error handling for missing domains in settings response

    frontend/src/api/index.js

    • Added error handling for missing domains in settings response.
    +3/-0     
    Dependencies
    2 files
    package.json
    Update frontend dependencies                                                         

    frontend/package.json

    • Updated several frontend dependencies to their latest versions.
    +13/-13 
    package.json
    Update worker dependencies                                                             

    worker/package.json

    • Updated several worker dependencies to their latest versions.
    +9/-9     
    Documentation
    2 files
    quick-start.md
    Add upgrade process documentation                                               

    vitepress-docs/docs/zh/guide/quick-start.md

    • Added a new section for the upgrade process.
    +23/-0   
    worker.md
    Add note about string format for variables                             

    vitepress-docs/docs/zh/guide/ui/worker.md

    • Added a note about string format for variables.
    +4/-1     
    Additional files (token-limit)
    2 files
    pnpm-lock.yaml
    ...                                                                                                           

    frontend/pnpm-lock.yaml

    ...

    +1297/-1300
    pnpm-lock.yaml
    ...                                                                                                           

    worker/pnpm-lock.yaml

    ...

    +562/-557

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request Bug fix Review effort [1-5]: 3 labels Aug 14, 2024
    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
    🔒 No security concerns identified
    ⚡ Key issues to review

    Possible Bug
    The showAdminPage computed property includes openSettings.value.disableAdminPasswordCheck but does not check if openSettings.value is defined, which could lead to a runtime error if openSettings is not initialized properly.

    Error Handling
    The error message for missing domains is hardcoded in English. Consider using a localization mechanism to support multiple languages.

    @dreamhunter2333 dreamhunter2333 merged commit c969c4b into main Aug 14, 2024
    1 check passed
    @dreamhunter2333 dreamhunter2333 deleted the feature/dev branch August 14, 2024 14:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Bug fix documentation Improvements or additions to documentation enhancement New feature or request Review effort [1-5]: 3
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant