Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed links for ambiguous USD exts to crate files under Python 3 #26

Merged

Conversation

jonjondev
Copy link
Contributor

This PR resolves an issue under Python 3, in which URIs to crate files with ambiguous USD file extensions (.usd) would fail to parse and fail silently as so:
image

Error: 'utf-8' codec can't decode byte 0xc0 in position 100: invalid start byte

The fix avoids reading any further than the 8 characters of the file header.

@mds-dwa mds-dwa self-assigned this Nov 29, 2021
Copy link
Contributor

@mds-dwa mds-dwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mds-dwa mds-dwa added bug Something isn't working python3 Python 3-specific issues and requests labels Nov 29, 2021
@mds-dwa mds-dwa merged commit a930cd1 into dreamworksanimation:dev Nov 29, 2021
@mds-dwa
Copy link
Contributor

mds-dwa commented Nov 30, 2021

Released in 0.12.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python3 Python 3-specific issues and requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants