Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Settings #810

Merged
merged 7 commits into from
Apr 27, 2024
Merged

Additional Settings #810

merged 7 commits into from
Apr 27, 2024

Conversation

xoascf
Copy link
Collaborator

@xoascf xoascf commented Apr 24, 2024

  • Project now uses C# 12
  • Reduces settings code boilerplate by simplifying getters and setters
  • Adds "do nothing" setting for middle click action in tasks (removes middle_mouse_to_close in translations as well, that string was quite large for it)
  • Removes code that checked if a directory existed when creating it anyway
  • Check for updates is now toggleable
  • Updates most property names in event handlers to use nameof instead of hardcoded names

@dremin
Copy link
Owner

dremin commented Apr 25, 2024

Nice!

Do you plan on adding a UI to toggle the updates setting? Anything else before it is ready for review?

@xoascf
Copy link
Collaborator Author

xoascf commented Apr 25, 2024

Do you plan on adding a UI to toggle the updates setting? Anything else before it is ready for review?

Yes, I was just testing that the changes I made did not cause a regression after the moves in settings code.

@xoascf xoascf marked this pull request as ready for review April 27, 2024 09:30
@xoascf xoascf merged commit 4f91054 into dremin:master Apr 27, 2024
3 checks passed
@xoascf xoascf deleted the additional-settings branch April 27, 2024 17:37
@SvetlanaSazonova
Copy link

SvetlanaSazonova commented Aug 24, 2024

Make Windows Longhorn builds 4015, 4002, 4005, 4081, 5001, 5098, 3706, 4008, 4011, 4020, 4029, 4032, 4042 (Lab06), 4050, 4051, 4053, 4093, 3790.1232, 3683, 3663, 4074 without Aero, 5048, Vista 5112, 5219, 5456 pre-RC1, 5215, 5231, 5259, 5270, 5308, 5384, 5469, 5568, 5600, 5840 taskbars!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants