-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-row functionality #928
base: master
Are you sure you want to change the base?
Conversation
Remaining tasks
(Many were hot-fixed by replacing drag functionality with a settings option) |
Here's every taskbar with 2 rows: |
Hey, thanks, this is looking great so far! I am going to try to take a deeper look at this soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start! In addition to the items within the review comments, I noticed a few layout correctness issues:
- Within the
Toolbar
and theNotifyIconList
controls: TheWrapPanel
within should have itsOrientation
property changed toVertical
when the taskbar is in a horizontal orientation and has more than 1 row. It should remainHorizontal
otherwise. - The classic Start button should not stretch vertically, it should keep its height and be aligned to the top. The XP start buttons should also be top aligned.
- For the XP and newer themes, the clock should change to the extended format that is used when in a vertical orientation.
I didn't pixel peep so there may be some other minor issues to address as well, but let's see how it looks after these changes! :)
RetroBar/PropertiesWindow.xaml
Outdated
<DockPanel> | ||
<Label VerticalAlignment="Center" | ||
Target="{Binding ElementName=cboEdgeSelect}"> | ||
<AccessText Text="{DynamicResource rowcount_text}" | ||
ToolTip="{DynamicResource rowcount_tip}" /> | ||
</Label> | ||
<ComboBox ItemsSource="{DynamicResource rowcount_options}" | ||
SelectedValue="{Binding Source={x:Static Settings:Settings.Instance}, Path=RowCount, UpdateSourceTrigger=PropertyChanged}" /> | ||
</DockPanel> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Since this does not affect vertical taskbars, lets disable it when the the Location is left or right.
- I think this would look better placed below the Location combobox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want it disabled or hidden?
RetroBar/Taskbar.xaml
Outdated
<WindowChrome.WindowChrome> | ||
<WindowChrome x:Name="Chrome" CaptionHeight="0" CornerRadius="0"/> | ||
</WindowChrome.WindowChrome> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed as it stands, and it currently breaks ClearType, so let's remove it.
RetroBar/Taskbar.xaml.cs
Outdated
DesiredWidth = Settings.Instance.TaskbarScale * (Application.Current.FindResource("TaskbarWidth") as double? ?? 0); | ||
DesiredHeight = DesiredRowHeight * Rows; | ||
MinHeight = DesiredRowHeight; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MinHeight doesn't seem to be needed, so I think it should be removed. Also, since it isn't being updated in RecalculateSize()
, things break :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. Another hold over from drag resizing
RetroBar/Taskbar.xaml.cs
Outdated
} | ||
} | ||
|
||
private void UpdateResizingOptions() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove all the commented out stuff for now.
RetroBar/Themes/System.xaml
Outdated
<Setter Property="VerticalAlignment" | ||
Value="Center"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't correct, the toolbars should keep their existing alignment. However, there is another related change that will need to be made for correctness, that I will comment separately on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't tray icons be aligned at top as well, like quick launch?
9ffa015
to
8b30505
Compare
8b30505
to
35844b7
Compare
Still a work in progress, but here's some screenshots: