Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-83326 Update archery/crossbow to work with new version of setuptools. #53

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

lriggs
Copy link

@lriggs lriggs commented Oct 4, 2023

A thirdparty library update in setuptools_scm broke ‘archery’ which is the build system used for building Dremio apache arrow.

The change causing the problem: correct git workdir passover and setuptools double call in · pypa/setuptools_scm@f7c075a

Archery just uses the latest setuptools_scm which resulted in it pulling in the new version with the change above. https://github.com/dremio/arrow/blob/dremio_24.3_12.0/dev/archery/setup.py#L38

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@lriggs lriggs merged commit f2dbe77 into dremio:dremio_24.3_12.0 Oct 4, 2023
5 of 8 checks passed
lriggs added a commit to lriggs/arrow that referenced this pull request Oct 5, 2023
lriggs added a commit that referenced this pull request Oct 6, 2023
* DX-83326 Update crossbow to pass in Configuration object to setuptools. (#53)

* DX-83326 Free up some disk space to prevent running out. (#54)

* DX-83326 Update crossbow to pass in Configuration object to setuptools.

* DX-83326 Remove some unused libraries to conserve disk space.
lriggs added a commit to lriggs/arrow that referenced this pull request Mar 12, 2024
lriggs added a commit to lriggs/arrow that referenced this pull request Apr 25, 2024
stevelorddremio pushed a commit to stevelorddremio/arrow that referenced this pull request Jun 14, 2024
lriggs added a commit to lriggs/arrow that referenced this pull request Sep 3, 2024
lriggs added a commit to lriggs/arrow that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants