-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#43] Switched to mariadb-10.11-drupal
upstream image.
#44
base: main
Are you sure you want to change the base?
Conversation
mariadb-10.4-drupal
upstream image.
f26a208
to
2b51e34
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=======================================
Coverage 92.94% 92.94%
=======================================
Files 2 2
Lines 85 85
=======================================
Hits 79 79
Misses 6 6 ☔ View full report in Codecov by Sentry. |
@tannguyen04 |
94e6b5f
to
8a0092d
Compare
Hi @AlexSkrypnyk
The SEED_IMAGE should be base image instead of drevops/mariadb-drupal-data:latest. So I made the changes like this and step 3 test image is passed https://github.com/drevops/mariadb-drupal-data/pull/44/files#diff-f29ded04891d5db51b96a02d4fa376df62b93ebecd2b909424d9d2a64c664989R84-R87
|
@tannguyen04
Is this locally or in CI? |
Hi @AlexSkrypnyk |
5eb63cb
to
95db327
Compare
mariadb-10.4-drupal
upstream image.mariadb-10.11-drupal
upstream image.
Closes #43
Checklist before requesting a review
[#123] Verb in past tense with dot at the end.
Changed
section about WHY something was done if this was not a normal implementationChanged
Screenshots