Skip to content

Commit

Permalink
Add net.peer.ip and net.host.ip to deprecated yaml (open-telemetr…
Browse files Browse the repository at this point in the history
…y#1029)

Co-authored-by: Trask Stalnaker <[email protected]>
  • Loading branch information
2 people authored and drewby committed May 23, 2024
1 parent 136a3c3 commit 022fdee
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 0 deletions.
22 changes: 22 additions & 0 deletions .chloggen/deprecated-net.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Use this changelog template to create an entry for release notes.
#
# If your change doesn't affect end users you should instead start
# your pull request title with [chore] or use the "Skip Changelog" label.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db)
component: net

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Add previously deprecated net attributes to registry

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
# The values here must be integers.
issues: [1029]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: These attributes were deprecated in 1.13
2 changes: 2 additions & 0 deletions docs/attributes-registry/network.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,10 @@ These attributes may be used for any network related operation.

| Attribute | Type | Description | Examples | Stability |
| ---------------------- | ------ | -------------------------------------------------------------------------------------- | -------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------- |
| `net.host.ip` | string | Deprecated, use `network.local.address`. | `192.168.0.1` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `network.local.address`. |
| `net.host.name` | string | Deprecated, use `server.address`. | `example.com` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `server.address`. |
| `net.host.port` | int | Deprecated, use `server.port`. | `8080` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `server.port`. |
| `net.peer.ip` | string | Deprecated, use `network.peer.address`. | `127.0.0.1` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `network.peer.address`. |
| `net.peer.name` | string | Deprecated, use `server.address` on client spans and `client.address` on server spans. | `example.com` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `server.address` on client spans and `client.address` on server spans. |
| `net.peer.port` | int | Deprecated, use `server.port` on client spans and `client.port` on server spans. | `8080` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `server.port` on client spans and `client.port` on server spans. |
| `net.protocol.name` | string | Deprecated, use `network.protocol.name`. | `amqp`; `http`; `mqtt` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `network.protocol.name`. |
Expand Down
12 changes: 12 additions & 0 deletions model/registry/deprecated/network.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,24 @@ groups:
stability: experimental
brief: Deprecated, use `server.port` on client spans and `client.port` on server spans.
examples: [8080]
- id: peer.ip
type: string
deprecated: "Replaced by `network.peer.address`."
stability: experimental
brief: Deprecated, use `network.peer.address`.
examples: '127.0.0.1'
- id: host.name
type: string
deprecated: "Replaced by `server.address`."
stability: experimental
brief: Deprecated, use `server.address`.
examples: ['example.com']
- id: host.ip
type: string
deprecated: "Replaced by `network.local.address`."
stability: experimental
brief: Deprecated, use `network.local.address`.
examples: '192.168.0.1'
- id: host.port
type: int
deprecated: "Replaced by `server.port`."
Expand Down

0 comments on commit 022fdee

Please sign in to comment.