Enable CLI Support for Ledger Hardware Wallets #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programming-runner
force-pushed
the
feat/usb-ledger
branch
from
374da96
to
0730aaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the CLI compatibility with Ledger hardware wallets, adhering to the URL scheme utilized by the Solana CLI when interacting with hardware wallets - as documented here.
Its a bit of a hack to get the Solana's adapters (which are intended for web) to work in a node.js environment - but thought it is better to re-use their code rather than copy/paste and have to maintain/review seperately.
Any feedback and suggestions for improvement are much appreciated.