bug: Popover not positioned correct with targetDim.left = 0

[davidruisinger]

Type: bug

Ionic Version: 2.x

Platform: ios 9 browser

Steps to reproduce:

1. Create a div that is positioned with left: 0 within the viewport
2. Add a (click) handler on the div to open a popover
3. The popover is not positioned according to the div but in the middle of the viewport

I check the source and I think this is because of this line (see: https://github.com/driftyco/ionic/blob/2.0/src/components/popover/popover.ts#L332)

let targetLeft = targetDim && targetDim.left || bodyWidth / 2;

Since targetDim.left = 0 it equals false and will fallback to bodyWidth / 2 which you can also see in the console.logs in the attached screenshot (I clicked on the yellow highlighted div).

[davidruisinger]

Not sure if this is the best solution but for me changing the lines 331 and 332 to this worked:

let targetTop = (targetDim && 'top' in targetDim)  ? targetDim.top : (bodyHeight / 2) - (popoverHeight / 2);
let targetLeft = (targetDim && 'left' in targetDim) ? targetDim.left : bodyWidth / 2;

[brandyscarney]

Fixed by PR #6900 by @flavordaaave. Thanks!