Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): allow target element to be positioned at left:0 #6900

Merged
merged 1 commit into from
Jun 14, 2016
Merged

fix(popover): allow target element to be positioned at left:0 #6900

merged 1 commit into from
Jun 14, 2016

Conversation

davidruisinger
Copy link
Contributor

Short description of what this resolves:

Popovers on elements that are positioned left:0 are now shown relative to the element instead of in the middle of the viewport.

Changes proposed in this pull request:

  • Get targetTop and targetLeft even when targetDim.left/targetDim.top is 0
  • Update test to include popovers on buttons that are positioned left:0 and right:0

Ionic Version: 2.x

Fixes: #6896

@brandyscarney brandyscarney self-assigned this Jun 14, 2016
@brandyscarney brandyscarney merged commit ea450d4 into ionic-team:2.0 Jun 14, 2016
@brandyscarney
Copy link
Member

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants