Changes to enable the JSDO to use xmlhttprequest-cookie #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working with the xmlhttprequest-cookie library, objects created using the wrapper are not recognized as instances of XMLHttpRequest. (instanceof XMLHttpRequest). Specified "XMLHttpRequest" as the function name so that code can check for constructor.name. The new behavior is consistent with web browser behavior where constructor.name for an XHR object is set. When working with FORM-based authentication from the JSDO. The Accept header always includes "*/*" because it is listed in the defaultHeaders variable. Code in the JSDOSession expects to be able to set the Accept header to "application/json". Changed line 545 to copy defaultHeaders to the headers variable and then delete the "Accept" property so that it can be set by calling setRequestHeader(). If the Accept header is not specified, then code in line 337 ensures that it is set to the default: "*/*". The new behavior is consistent with web browser behavior where the Accept header is not set by default. See: https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/setRequestHeader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with the xmlhttprequest-cookie library, objects created using the wrapper are not recognized as instances of XMLHttpRequest. (instanceof XMLHttpRequest).
Specified "XMLHttpRequest" as the function name so that code can check for constructor.name.
The new behavior is consistent with web browser behavior where constructor.name for an XHR object is set.
When working with FORM-based authentication from the JSDO.
The Accept header always includes "/" because it is listed in the defaultHeaders variable.
Code in the JSDOSession expects to be able to set the Accept header to "application/json".
Changed line 545 to copy defaultHeaders to the headers variable and then delete the "Accept" property so that it can be set by calling setRequestHeader(). If the Accept header is not specified, then code in line 337 ensures that it is set to the default: "/".
The new behavior is consistent with web browser behavior where the Accept header is not set by default.
See:
https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/setRequestHeader