[BUG]: TypeError: Cannot read properties of undefined (reading 'compositePrimaryKeys') #2344

ghost · 2024-05-17T20:16:49Z

What version of `drizzle-orm` are you using?

0.30.10

What version of `drizzle-kit` are you using?

0.21.2

Describe the Bug

if I have tables with no composite primary keys(table => pk: primaryKey(....) , then i can change my column names and do whatever i want with no issue in push.

issues arises when:

changing column names, adding new columns, tables to schema that any table has composite primary key.
if schema already exists in database and i want to add composite primary key.

everytime before pushing new version of the schema, i have to drop all my tables in db. otherwise drizzle-kit push command keeps failing with this error.

Expected behavior

No response

Environment & setup

next.js 14 app router application

The text was updated successfully, but these errors were encountered:

AndriiSherman · 2024-05-22T14:49:54Z

This should be fixed in [email protected]. If the issue persists, feel free to reopen it!

sakulstra · 2024-05-28T15:44:40Z

I can confirm the issue still exists even on 22 beta.

As a variant of the problem, the same issue exists when renaming a table, not only a field.

BrandonWeng · 2024-05-28T16:11:45Z

Also having the same issues

drizzle-kit: v0.21.4
drizzle-orm: v0.30.10

No config path provided, using default path

Using 'pg' driver for database querying
[✓] Pulling schema from database...TypeError: Cannot read properties of undefined (reading 'compositePrimaryKeys')
    at /app/node_modules/.pnpm/[email protected]/node_modules/drizzle-kit/bin.cjs:19393:67
    at Array.map (<anonymous>)
    at prepareDeleteCompositePrimaryKeyPg (/Users/brandon/brevian/platform/control-plane/app/node_modules/.pnpm/[email protected]/node_modules/drizzle-kit/bin.cjs:19387:33)
    at applyPgSnapshotsDiff (/app/node_modules/.pnpm/[email protected]/node_modules/drizzle-kit/bin.cjs:19890:33)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async preparePgPush /app/node_modules/.pnpm/[email protected]/node_modules/drizzle-kit/bin.cjs:22139:52)
    at async pgPush (/app/node_modules/.pnpm/[email protected]/node_modules/drizzle-kit/bin.cjs:114468:26)
    at async Command.<anonymous> (/app/node_modules/.pnpm/[email protected]/node_modules/drizzle-kit/bin.cjs:121480:7)

lhorak · 2024-05-30T12:40:58Z

I ran into the same issue, and I suspect this is related to naming conventions (camelCase vs snake case). As an example:

export const table = pgTable(
  "tableName",
  {
    timestamp: timestamp("timestamp").notNull().defaultNow(),
    userName: text("ws_id").notNull(),
  },
  (tb) => ({
    pk: primaryKey({ columns: [tb.userName, tb.timestamp] }),
  })
);

this will correctly create the userName_timestamp_pk, however, when additional changes occur and you're trying to push, drizzle-kit is trying to find username_timestamp_pk which cannot be found, thus throwing the undefined error.

I converted my table names to snake case and it seems like this solved the issue

LavaToaster · 2024-06-01T15:22:25Z

I solved this issue by modifying the package source for [email protected], now have a manual patch for drizzle kit.

diff --git a/bin.cjs b/bin.cjs
index e5e7558dc577c4fba1ca4fe508a5851b4e8f4c91..e42056bb4937c68c0598be71ea8b63cea437dccc 100755
--- a/bin.cjs
+++ b/bin.cjs
@@ -27620,7 +27620,7 @@ var init_jsonStatements = __esm({
           tableName,
           data: it,
           schema: schema5,
-          constraintName: json1.tables[`${schema5}.${tableName}`].compositePrimaryKeys[PgSquasher.unsquashPK(it).name].name
+          constraintName: json1.tables[`${schema5 || "public"}.${tableName}`].compositePrimaryKeys[PgSquasher.unsquashPK(it).name].name
         };
       });
     };

goldoraf · 2024-06-06T07:31:13Z

I can confirm the issue is still there and that the above fix from @LavaToaster solves the problem. @LavaToaster would you like to submit a PR? @AndriiSherman could you please reopen the issue?

LavaToaster · 2024-06-06T07:33:13Z

@goldoraf drizzle kit is not open source yet. So, cannot.

AlonMiz · 2024-06-10T12:17:52Z

why is this marked as closed? can you reopen this? 🙏

dkmooers · 2024-06-10T20:11:20Z

+1 to reopening this. Using drizzle-kit generate and then drizzle-kit migrate works, but not drizzle-kit push (I get the error described here).

waltershewmake · 2024-06-19T00:42:47Z

Experiencing this issue as well when attempting to rename a table during both drizzle-kit generate and drizzle-kit push

juanamd · 2024-06-19T19:33:23Z

Same issue on my end

Johnathon332 · 2024-06-21T09:04:44Z

Yep getting this issue as well. Whatever schema change I make, when I run push I just get that error

NickWoodward · 2024-06-23T00:37:47Z

Yeah same issue here

nacho-vazquez · 2024-06-25T21:28:07Z

@AndriiSherman, could you please reopen this issue? It is still present. @LavaToaster's solution is working, but it would be great if the patch landed in drizzle-kit.

Thank you!

tgdn · 2024-06-28T12:17:14Z

The issue still persists in [email protected]

migrate doesn't work either.

cawak · 2024-06-28T14:15:05Z

Yes, the issue still persists. This error is triggered once I run the generate command.

I get this error once I rename a table name (snake case) with a composite prime key.

Versions:
"drizzle-orm": "^0.31.2"
"drizzle-kit": "^0.22.7"

Please re-open it

mustafamoe · 2024-06-29T11:17:51Z

I am on latest versions

"drizzle-orm": "^0.31.2"
"drizzle-kit": "^0.22.7"

Drizzle is not usable without solving this issue and it's closed!!!! it's almost 2 months :/

Thanks for @LavaToaster I can continue working!

Please reopen the issue...

dkmooers · 2024-06-29T11:21:35Z

I am on latest versions

"drizzle-orm": "^0.31.2" "drizzle-kit": "^0.22.7"

Drizzle is not usable without solving this issue and it's closed!!!! it's almost 2 months. maybe it was a mistake using drizzle this early. what a joke :/

Thanks for @LavaToaster I can continue working!

Please reopen the issue...

Just want to point out that this is open source software and there are real good people behind making it, putting in a ton of work, benefiting a lot of people

mustafamoe · 2024-06-29T11:24:24Z

I am on latest versions
"drizzle-orm": "^0.31.2" "drizzle-kit": "^0.22.7"
Drizzle is not usable without solving this issue and it's closed!!!! it's almost 2 months. maybe it was a mistake using drizzle this early. what a joke :/
Thanks for @LavaToaster I can continue working!
Please reopen the issue...

Just want to point out that this is open source software and there are real good people behind making it, putting in a ton of work, benefiting a lot of people

Still people are getting paid working on it, correct me if am wrong.

dkmooers · 2024-06-29T11:26:33Z

I am on latest versions
"drizzle-orm": "^0.31.2" "drizzle-kit": "^0.22.7"
Drizzle is not usable without solving this issue and it's closed!!!! it's almost 2 months. maybe it was a mistake using drizzle this early. what a joke :/
Thanks for @LavaToaster I can continue working!
Please reopen the issue...

Just want to point out that this is open source software and there are real good people behind making it, putting in a ton of work, benefiting a lot of people

Still people are getting paid working on it, correct me if am wrong.

I can't speak to that, but I can say that even if I was getting paid to work on Drizzle, a comment like "what a joke" would be pretty off-putting and not feel that good to hear. I'm all for keeping this a supportive environment

mustafamoe · 2024-06-29T11:29:25Z

I am on latest versions
"drizzle-orm": "^0.31.2" "drizzle-kit": "^0.22.7"
Drizzle is not usable without solving this issue and it's closed!!!! it's almost 2 months. maybe it was a mistake using drizzle this early. what a joke :/
Thanks for @LavaToaster I can continue working!
Please reopen the issue...

Just want to point out that this is open source software and there are real good people behind making it, putting in a ton of work, benefiting a lot of people

Still people are getting paid working on it, correct me if am wrong.

I can't speak to that, but I can say that even if I was getting paid to work on Drizzle, a comment like "what a joke" would be pretty off-putting and not feel that good to hear. I'm all for keeping this a supportive environment

Sorry if anybody took it offensively, but almost 2 months for 1 line fix kinda funny no 😅

AndriiSherman · 2024-06-29T11:41:09Z

Hey everyone, sorry for the late response. I was really busy with other features we were working on. Let me push the patch update now so you can be unblocked

AndriiSherman · 2024-06-29T11:41:38Z

@LavaToaster thanks a lot!

AndriiSherman · 2024-06-29T11:51:47Z

Ok, yeah, it was my bad for not adding public by default. I'm publishing a patch update and will mention @LavaToaster as the one who fixed it

AndriiSherman · 2024-06-29T12:04:55Z

please check [email protected], should have the fix for that

johaven · 2024-08-15T10:14:46Z

+1 with [email protected] & [email protected] & no composite primary key

mees-van-wel · 2024-08-19T21:49:43Z

+1 I encountered this issue when running the drizzle-kit generate command. The process started as expected, resolving enum and table conflicts, and renaming columns. However, it threw a TypeError related to compositePrimaryKeys after resolving all conflicts.

[email protected] & [email protected]

Here’s the output leading up to the error:

> drizzle-kit generate

No config path provided, using default 'drizzle.config.ts'
Reading config file 'C:\Users\<user>\projects\<project>\back-end\drizzle.config.ts'
~ reservations_to_product_instances_cycle › reservation_product_instances_cycle enum will be renamed/moved
~ reservations_to_product_instances_status › reservation_product_instances_status enum will be renamed/moved
--- all enum conflicts resolved ---

+ customer_projects table will be created
+ projects table will be created
~ reservations_to_invoices › reservations_invoices table will be renamed/moved
~ reservations_to_product_instances › reservation_product_instances table will be renamed/moved
+ workflow_steps table will be created
+ workflow_workflow_steps table will be created
+ workflows table will be created
--- all table conflicts resolved ---

~ position › order column will be renamed
--- all columns conflicts in form_elements table resolved ---

~ position › order column will be renamed
--- all columns conflicts in form_sections table resolved ---

TypeError: Cannot read properties of undefined (reading 'compositePrimaryKeys')
    at C:\Users\<user>\projects\<project>\back-end\node_modules\.pnpm\[email protected]\node_modules\drizzle-kit\bin.cjs:25762:79
    at Array.map (<anonymous>)
    at prepareDeleteCompositePrimaryKeyPg (C:\Users\<user>\projects\<project>\back-end\node_modules\.pnpm\[email protected]\node_modules\drizzle-kit\bin.cjs:25756:33)
    at applyPgSnapshotsDiff (C:\Users\<user>\projects\<project>\back-end\node_modules\.pnpm\[email protected]\node_modules\drizzle-kit\bin.cjs:26349:33)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async prepareAndMigratePg (C:\Users\<user>\projects\<project>\back-end\node_modules\.pnpm\[email protected]\node_modules\drizzle-kit\bin.cjs:28671:42)
    at async Object.handler (C:\Users\<user>\projects\<project>\back-end\node_modules\.pnpm\[email protected]\node_modules\drizzle-kit\bin.cjs:82929:7)
    at async rawCli (C:\Users\<user>\projects\<project>\back-end\node_modules\.pnpm\[email protected]\node_modules\drizzle-kit\bin.cjs:81492:5)
    at async run (C:\Users\<user>\projects\<project>\back-end\node_modules\.pnpm\[email protected]\node_modules\drizzle-kit\bin.cjs:81500:5)

nick-boxem · 2024-08-28T20:11:21Z

I'm currently experiencing this issue on "drizzle-kit": "^0.21.0" and "drizzle-orm": "^0.29.1", where we modified a table to have a composite primary key, then ran drizzle-kit generate and got:

TypeError: Cannot read properties of undefined (reading 'compositePrimaryKeys')
    at C:\Users\13435\Boxem\packages\core-db\node_modules\drizzle-kit\bin.cjs:19331:67
    at Array.map (<anonymous>)
    at prepareAddCompositePrimaryKeyPg (C:\Users\13435\Boxem\packages\core-db\node_modules\drizzle-kit\bin.cjs:19324:33)
    at applyPgSnapshotsDiff (C:\Users\13435\Boxem\packages\core-db\node_modules\drizzle-kit\bin.cjs:19833:31)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async prepareAndMigratePg (C:\Users\13435\Boxem\packages\core-db\node_modules\drizzle-kit\bin.cjs:22056:42)
    at async Command.<anonymous> (C:\Users\13435\Boxem\packages\core-db\node_modules\drizzle-kit\bin.cjs:114259:5)

Are there any known workarounds? This is a fairly serious blocker for us.

MonteLogic · 2024-08-29T03:57:49Z

For me the only thing that worked was DROPing the table and then runnning the Drizzle scripts again. I know this won't work well in production, but it worked for me.

Lemmmy · 2024-09-06T21:09:35Z

I've run into this error by renaming a table without any composite primary keys (though it does have a composite index) on [email protected], [email protected], MySQL, Bun v1.1.26

~ indexedFile › indexedFiles table will be renamed/moved
--- all table conflicts resolved ---

TypeError: Cannot read properties of undefined (reading 'compositePrimaryKeys')
    at ...\node_modules\drizzle-kit\bin.cjs:25889:51
    at Array.map (<anonymous>)
    at prepareDeleteCompositePrimaryKeyMySql (...\node_modules\drizzle-kit\bin.cjs:25884:33)
    at ...\node_modules\drizzle-kit\bin.cjs:26810:31
    at Array.forEach (<anonymous>)
    at applyMysqlSnapshotsDiff (...\node_modules\drizzle-kit\bin.cjs:26789:21)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async prepareAndMigrateMysql (...\node_modules\drizzle-kit\bin.cjs:28838:54)
    at async Object.handler (...\node_modules\drizzle-kit\bin.cjs:83525:7)
    at async run (...\node_modules\drizzle-kit\bin.cjs:82064:7)

omaziarz · 2024-09-11T14:15:57Z

Well for all of you guys struggling with this there is a temporary workaround until they fix this.

1 - Go to the last XX_snapshot.json
2 - Manually delete what's inside of the compositePrimaryKeys object of the tables that you are renaming
3 - drizzle-kit generate
4 - in the newly generated migration file at the very beginning of the file, for each constraint that you deleted in step 2, you need to write the corresponding ALTER TABLE <name_of_the_table> DROP CONSTRAINT <name_of_the_constraint>;
5 - drizzle-kit migrate

I hope this is clear enough and if you wanna be sure you don't break the db, don't rename multiple tables at once its gonna be easier to handle for you

brennanbutler01 · 2024-09-22T19:18:02Z

Well for all of you guys struggling with this there is a temporary workaround until they fix this.

1 - Go to the last XX_snapshot.json 2 - Manually delete what's inside of the compositePrimaryKeys object of the tables that you are renaming 3 - drizzle-kit generate 4 - in the newly generated migration file at the very beginning of the file, for each constraint that you deleted in step 2, you need to write the corresponding ALTER TABLE <name_of_the_table> DROP CONSTRAINT <name_of_the_constraint>; 5 - drizzle-kit migrate

I hope this is clear enough and if you wanna be sure you don't break the db, don't rename multiple tables at once its gonna be easier to handle for you

this helped me out, thanks. was running into this with:
"drizzle-kit": "^0.23.0",

mustafamoe · 2024-10-05T08:29:56Z

I know this doesn't help solve the issue, but I will comment anyway.

We migrated to prisma

Why:
1 - Mature/Stable/Feature-rich.
2 - Prisma TypedSQL
3 - Great DX
4 - Fast development
5 - Speed is used to market Drizzle ORM. Prisma is fast. On the benchmark they made, it shows that Prisma can handle 2.4k req/sec, in other words, 8,640,000 req/hour. 😅 Come on now, do you really think you will hit that number any time soon? Most apps will not early on. Also, you have a lot of room for optimizations like caching, rate limiting, etc. If your app REALLY cares about performance, then sure, you could use Drizzle ORM or Kysely, but not many products do. Although now Prisma is introducing TypedSQL, which is the best of both worlds, it's not worth it to use Drizzle ORM or Kysely.

Actually think before using anything. Don't just use what people say is good, e.g., "Theo," "Prime," "Josh," and a lot more. It may be good, but first look at your use case, and then judge if it's good or not. Don't use alpha/beta libraries in production. it may be obvious, but shiny things can sometimes cloud judgement.

LeulAria · 2024-10-05T08:54:34Z

I know this doesn't help solve the issue, but I will comment anyway.

We migrated to prisma

Why:
1 - Mature/Stable/Feature-rich.
2 - Prisma TypedSQL
3 - Great DX
4 - Fast development
5 - Speed is used to market Drizzle ORM. Prisma is fast. On the benchmark they made, it shows that Prisma can handle 2.4k req/sec, in other words, 8,640,000 req/hour. 😅 Come on now, do you really think you will hit that number any time soon? Most apps will not early on. Also, you have a lot of room for optimizations like caching, rate limiting, etc. If your app REALLY cares about performance, then sure, you could use Drizzle ORM or Kysely, but not many products do. Although now Prisma is introducing TypedSQL, which is the best of both worlds, it's not worth it to use Drizzle ORM or Kysely.

Actually think before using anything. Don't just use what people say is good, e.g., "Theo," "Prime," "Josh," and a lot more. It may be good, but first look at your use case, and then judge if it's good or not. Don't use alpha/beta libraries in production. it may be obvious, but shiny things can sometimes cloud judgement.

I haven't seen any benefit from drizzle except the Drizzle studio UI 😉 which you can't even deploy and use.

Prisma for schema and migration + Kysely.
is the best combo I found don't even mention performance or DX.

abdullah-hallaq · 2024-10-05T09:49:42Z

I know this doesn't help solve the issue, but I will comment anyway.
We migrated to prisma
Why:
1 - Mature/Stable/Feature-rich.
2 - Prisma TypedSQL
3 - Great DX
4 - Fast development
5 - Speed is used to market Drizzle ORM. Prisma is fast. On the benchmark they made, it shows that Prisma can handle 2.4k req/sec, in other words, 8,640,000 req/hour. 😅 Come on now, do you really think you will hit that number any time soon? Most apps will not early on. Also, you have a lot of room for optimizations like caching, rate limiting, etc. If your app REALLY cares about performance, then sure, you could use Drizzle ORM or Kysely, but not many products do. Although now Prisma is introducing TypedSQL, which is the best of both worlds, it's not worth it to use Drizzle ORM or Kysely.
Actually think before using anything. Don't just use what people say is good, e.g., "Theo," "Prime," "Josh," and a lot more. It may be good, but first look at your use case, and then judge if it's good or not. Don't use alpha/beta libraries in production. it may be obvious, but shiny things can sometimes cloud judgement.

I haven't seen any benefit from drizzle except the Drizzle studio UI 😉 which you can't even deploy and use.

Prisma for schema and migration + Kysely. is the best combo I found don't even mention performance or DX.

Prisma Studio was actually the inspiration behind Drizzle Studio. 😉

waltershewmake · 2024-10-05T14:56:05Z

Using Prisma is wild. It’s so slow. Requests per second is a terrible benchmark. Prisma queries are extremely unoptimized. All of these drizzle errors are actually quite simple to overcome with basic knowledge of SQL. Prisma is a prime example of why people hate ORMs. Drizzle is a prime example of why ORMs can work. Migrating to Prisma is not a solution. Anyone who has actually used Prisma can tell you that.

…

On Sat, Oct 5 2024 at 3:50 AM, Abdullah Mohammed ***@***.***> wrote: I know this doesn't help solve the issue, but I will comment anyway. We migrated to prisma Why: 1 - Mature/Stable/Feature-rich. 2 - Prisma TypedSQL 3 - Great DX 4 - Fast development 5 - Speed is used to market Drizzle ORM. Prisma is fast. On the benchmark they made, it shows that Prisma can handle 2.4k req/sec, in other words, 8,640,000 req/hour. 😅 Come on now, do you really think you will hit that number any time soon? Most apps will not early on. Also, you have a lot of room for optimizations like caching, rate limiting, etc. If your app REALLY cares about performance, then sure, you could use Drizzle ORM or Kysely, but not many products do. Although now Prisma is introducing TypedSQL, which is the best of both worlds, it's not worth it to use Drizzle ORM or Kysely. Actually think before using anything. Don't just use what people say is good, e.g., "Theo," "Prime," "Josh," and a lot more. It may be good, but first look at your use case, and then judge if it's good or not. Don't use alpha/beta libraries in production. it may be obvious, but shiny things can sometimes cloud judgement. I haven't seen any benefit from drizzle except the Drizzle studio UI 😉 which you can't even deploy and use. Prisma for schema and migration + Kysely. is the best combo I found don't even mention performance or DX. Prisma Studio was actually the inspiration behind Drizzle Studio. 😉 image.png (view on web) <https://github.com/user-attachments/assets/1beb6b92-05e5-41ed-a870-c34a1e727d09> — Reply to this email directly, view it on GitHub <#2344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAHO2WSDLDCPZQGO4NIIN3ZZ6Y5TAVCNFSM6AAAAABH4XHQ46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGAYDANRWHE> . You are receiving this because you commented.Message ID: ***@***.***>

abdullah-hallaq · 2024-10-05T15:22:44Z

Ah yes, Prisma—the villain of ORMs. Funny how Dub processes tons of data daily without 'unoptimized' issues. Maybe it's not Prisma, but skill issues 😉.

Keep in mind that this Drizzle issue has been open for more than two months with a one-liner fix just sitting there :)

waltershewmake · 2024-10-05T15:27:13Z

“Ah yes,” funny how I don’t even know what Dub is. It must be irrelevant just like your comments here “😉.” If you don’t have a solution then take your comments somewhere else

…

On Sat, Oct 5 2024 at 9:23 AM, Abdullah Mohammed ***@***.***> wrote: Ah yes, Prisma—the villain of ORMs. Funny how Dub processes tons of data daily without 'unoptimized' issues. Maybe it's not Prisma, but skill issues 😉. Keep in mind that this Drizzle issue has been open for more than two months with a one-liner fix just sitting there :) — Reply to this email directly, view it on GitHub <#2344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAHO2QHQABJ2PVFHYLYVYDZZ775ZAVCNFSM6AAAAABH4XHQ46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGA4TCNBTGI> . You are receiving this because you commented.Message ID: ***@***.***>

abdullah-hallaq · 2024-10-05T15:32:12Z

“Ah yes,” funny how I don’t even know what Dub is. It must be irrelevant just like your comments here “😉.” If you don’t have a solution then take your comments somewhere else
…
On Sat, Oct 5 2024 at 9:23 AM, Abdullah Mohammed @.> wrote: Ah yes, Prisma—the villain of ORMs. Funny how Dub processes tons of data daily without 'unoptimized' issues. Maybe it's not Prisma, but skill issues 😉. Keep in mind that this Drizzle issue has been open for more than two months with a one-liner fix just sitting there :) — Reply to this email directly, view it on GitHub <#2344 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAHO2QHQABJ2PVFHYLYVYDZZ775ZAVCNFSM6AAAAABH4XHQ46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGA4TCNBTGI . You are receiving this because you commented.Message ID: @.>

Haha, I know, it’s funny! Check out Dub. Also, maybe you know Cal.com? You should check out what Prisma has been doing lately!

waltershewmake · 2024-10-05T15:34:38Z

johaven · 2024-10-05T15:36:33Z

Drizzle - the ORM that doesn't patch fast enough :D
If some are convinced by Prisma, why come to a drizzle issue and spam? Frustration? Regrets?
I envy you for having so much time to waste :P

LeulAria · 2024-10-05T15:43:34Z

Drizzle - the ORM that doesn't patch fast enough :D
If some are convinced by Prisma, why come to a drizzle issue and spam? Frustration? Regrets?
I envy you for having so much time to waste :P

Yeah save the generation use kysely 🤣

abdullah-hallaq · 2024-10-05T15:56:23Z

Good enough! Also, no one said Drizzle isn’t good, I like it It’s pushing every ORM (Prisma one of them ofc :) to improve what it’s lacking

mustafamoe · 2024-10-05T16:02:12Z

I am sorry for making this mess, i shouldn't have commented here. please stop!

na-ji · 2024-10-14T19:06:17Z

Well for all of you guys struggling with this there is a temporary workaround until they fix this.

1 - Go to the last XX_snapshot.json
2 - Manually delete what's inside of the compositePrimaryKeys object of the tables that you are renaming
3 - drizzle-kit generate
4 - in the newly generated migration file at the very beginning of the file, for each constraint that you deleted in step 2, you need to write the corresponding ALTER TABLE <name_of_the_table> DROP CONSTRAINT <name_of_the_constraint>;
5 - drizzle-kit migrate

I hope this is clear enough and if you wanna be sure you don't break the db, don't rename multiple tables at once its gonna be easier to handle for you

For people that just landed here and are lost in all the spam, this comment is the temporary workaround 🔝

Connorelsea · 2024-10-19T16:39:03Z

Getting this issue as well when renaming a table/column and running drizzle-kit generate. On latest drizzle ORM v0.35.2 and kit v0.26.2. I worked around this by leaving the old table for now and creating a new table with the new name instead.

~ template_to_token_definitions › template_definition_to_token_definitions table will be renamed/moved
--- all table conflicts resolved ---


~ template_id › template_definition_id column will be renamed
--- all columns conflicts in template_definition_to_token_definitions table resolved ---

TypeError: Cannot read properties of undefined (reading 'compositePrimaryKeys')
    at /Users/connorelsea/Projects/home-gen-v2/node_modules/drizzle-kit/bin.cjs:26259:79
    at Array.map (<anonymous>)
    at prepareDeleteCompositePrimaryKeyPg (/Users/connorelsea/Projects/home-gen-v2/node_modules/drizzle-kit/bin.cjs:26253:33)
    at applyPgSnapshotsDiff (/Users/connorelsea/Projects/home-gen-v2/node_modules/drizzle-kit/bin.cjs:27128:33)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async prepareAndMigratePg (/Users/connorelsea/Projects/home-gen-v2/node_modules/drizzle-kit/bin.cjs:29745:42)
    at async Object.handler (/Users/connorelsea/Projects/home-gen-v2/node_modules/drizzle-kit/bin.cjs:84806:7)
    at async run (/Users/connorelsea/Projects/home-gen-v2/node_modules/drizzle-kit/bin.cjs:83343:7)

AndriiSherman · 2024-11-06T19:40:36Z

Was fixed in [email protected]

didagu · 2024-11-12T18:55:01Z

I tried with [email protected] and [email protected] but I still get an error.

TypeError: Cannot read properties of undefined (reading 'columns')

L-Mario564 · 2024-11-13T04:09:24Z

I tried with [email protected] and [email protected] but I still get an error.

TypeError: Cannot read properties of undefined (reading 'columns')

This is a different error though. Might be worth creating a new issue that is separate from this one with steps to reproduce this bug.

didagu · 2024-11-14T10:11:10Z

@L-Mario564 Kindly check it out #3539

ghost added the bug Something isn't working label May 17, 2024

realmikesolo added the drizzle/kit label May 21, 2024

AndriiSherman closed this as completed May 22, 2024

cawak mentioned this issue Jun 28, 2024

[BUG]: Cannot rename table with composite primary keys #2533

Closed

AndriiSherman reopened this Jun 29, 2024

AndriiSherman reopened this Aug 12, 2024

L-Mario564 mentioned this issue Sep 12, 2024

Batch of bugfixes for Kit #2959

Merged

L-Mario564 self-assigned this Oct 22, 2024

L-Mario564 added the priority Will be worked on next label Oct 22, 2024

AndriiSherman closed this as completed Nov 6, 2024

[BUG]: TypeError: Cannot read properties of undefined (reading 'compositePrimaryKeys') #2344

[BUG]: TypeError: Cannot read properties of undefined (reading 'compositePrimaryKeys') #2344

Comments

ghost commented May 17, 2024 • edited by ghost Loading

What version of drizzle-orm are you using?

What version of drizzle-kit are you using?

Describe the Bug

Expected behavior

Environment & setup

AndriiSherman commented May 22, 2024

sakulstra commented May 28, 2024

BrandonWeng commented May 28, 2024

lhorak commented May 30, 2024 • edited Loading

LavaToaster commented Jun 1, 2024

goldoraf commented Jun 6, 2024

LavaToaster commented Jun 6, 2024

AlonMiz commented Jun 10, 2024

dkmooers commented Jun 10, 2024

waltershewmake commented Jun 19, 2024

juanamd commented Jun 19, 2024

Johnathon332 commented Jun 21, 2024 • edited Loading

NickWoodward commented Jun 23, 2024

nacho-vazquez commented Jun 25, 2024

tgdn commented Jun 28, 2024 • edited Loading

cawak commented Jun 28, 2024

mustafamoe commented Jun 29, 2024 • edited Loading

dkmooers commented Jun 29, 2024

mustafamoe commented Jun 29, 2024

dkmooers commented Jun 29, 2024

mustafamoe commented Jun 29, 2024

AndriiSherman commented Jun 29, 2024

AndriiSherman commented Jun 29, 2024

AndriiSherman commented Jun 29, 2024

AndriiSherman commented Jun 29, 2024

johaven commented Aug 15, 2024

mees-van-wel commented Aug 19, 2024 • edited Loading

nick-boxem commented Aug 28, 2024

MonteLogic commented Aug 29, 2024

Lemmmy commented Sep 6, 2024 • edited Loading

omaziarz commented Sep 11, 2024 • edited Loading

brennanbutler01 commented Sep 22, 2024 • edited Loading

mustafamoe commented Oct 5, 2024

LeulAria commented Oct 5, 2024

abdullah-hallaq commented Oct 5, 2024

waltershewmake commented Oct 5, 2024 via email

abdullah-hallaq commented Oct 5, 2024

waltershewmake commented Oct 5, 2024 via email

abdullah-hallaq commented Oct 5, 2024

waltershewmake commented Oct 5, 2024

johaven commented Oct 5, 2024

LeulAria commented Oct 5, 2024

abdullah-hallaq commented Oct 5, 2024

mustafamoe commented Oct 5, 2024

na-ji commented Oct 14, 2024

Connorelsea commented Oct 19, 2024 • edited Loading

AndriiSherman commented Nov 6, 2024

didagu commented Nov 12, 2024

L-Mario564 commented Nov 13, 2024

didagu commented Nov 14, 2024 • edited Loading

ghost commented May 17, 2024 •

edited by ghost

Loading

What version of `drizzle-orm` are you using?

What version of `drizzle-kit` are you using?

lhorak commented May 30, 2024 •

edited

Loading

Johnathon332 commented Jun 21, 2024 •

edited

Loading

tgdn commented Jun 28, 2024 •

edited

Loading

mustafamoe commented Jun 29, 2024 •

edited

Loading

mees-van-wel commented Aug 19, 2024 •

edited

Loading

Lemmmy commented Sep 6, 2024 •

edited

Loading

omaziarz commented Sep 11, 2024 •

edited

Loading

brennanbutler01 commented Sep 22, 2024 •

edited

Loading

Connorelsea commented Oct 19, 2024 •

edited

Loading

didagu commented Nov 14, 2024 •

edited

Loading