[Pg] Add implementation of geography type for PostGIS extension #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinsimonklein
force-pushed
the
pg-postgis-geography-type
branch
from
e468ac1
to
b62b3f1
Compare
robinsimonklein
force-pushed
the
pg-postgis-geography-type
branch
from
419e482
to
f4576b3
Compare
robinsimonklein
force-pushed
the
pg-postgis-geography-type
branch
from
f4576b3
to
bd65abd
Compare
|
Hope this gets approval, having geometry but not geography is a weird choice. Good work! |
|
Thanks for this. Any intel on what the PR will make it into main? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, as mentioned here, Drizzle ORM only has basic support for the PostGIS extension, with only the
geometrycolumn type available. PostGIS also offers ageographycolumn type, which is often more suitable for storing real-world location coordinates because it uses the Earth's spherical representation for calculations.This is a first attempt to implement the
geographytype, based on the current implementation ofgeometry. Both types work similarly, with the following differences:sridparameter has been removed, as thegeographytype only works with SRID 4326.xymode has been renamed tojson, andxandyhave been replaced withlonandlat, which makes more sense for geographic coordinates.