-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed guard scroll causing engine yard deploy failure due to inconsistent gems between dev & prod #30
base: master
Are you sure you want to change the base?
Conversation
…is generated, instead of each time in the gemfile; otherwise it fails deploy scripts that check the bundle on a server with a different os than dev
I never saw this because I wasn't using notifications locally and had commented out those lines. I'll test this out for the next release. Thanks! |
@allangrant, I'm confused about why this change actually fixes anything. There may be a better solution. Let's chat. |
@thommahoney Definitely open to better solutions. This change at least fixes the problem by making sure the Gemfile is interpreted the same way when it's read on production and in development that are different OS. With the switch on the operating in the Gemfile, it looks like Gemfile.lock hasn't been updated when Gemfile.lock is generated on a different operating system - because even gems that are only used in development are included in the lock file. |
…a recent git diff: scroll memorize NEW_SCROLL
The guard scroll put some code in the Gemfile like this:
This caused problems when deploying to Engine Yard (or any system with a different os than the development machine) because the expected gems weren't in the lock file.
This patch moves the switch to occur when the app is created. (A scroll is usually cast in the development environment, right?)
It only puts one set of gems in the gemfile and fixes Engine Yard deploy. Output in Gemfile (for a mac system):