Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:refactor eventypes component #17

Merged
merged 3 commits into from
Jul 8, 2022
Merged

chore:refactor eventypes component #17

merged 3 commits into from
Jul 8, 2022

Conversation

danielotieno
Copy link
Collaborator

Make sure the checklist below is checked before PR merge, mark if not applicable

PR Checklist

  • UI created matched design
  • For every color class added, dark: is defined, images have alt and _blank links have rel
  • API is integrated as required
  • Page is responsive

What is the Purpose?

Briefly describe what the PR addresses

What was the approach?

Briefly describe the approach used to address the issue

Are any concerns to be addressed further before or after merging this PR?

State some additional info if any. For instance, running install or setting some environment variable(s)

Mentions?

Mention persons you'd like to review this PR

Issue(s) affected?

List of issues addressed by this PR.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @danielotieno for your first pull Request!

Copy link
Member

@manuelgeek manuelgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add './constant/**/*.{js,ts}', in tailwind.config.js under content to avoid the classes there being purged

also in gallery, the images spacings are gone
maybe add <div className='p-0.5'> wapp around

Copy link
Member

@manuelgeek manuelgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuelgeek manuelgeek merged commit 0366808 into dev Jul 8, 2022
@manuelgeek manuelgeek deleted the refactor-duplicates branch July 8, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants