Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI-0]: Added Pr in issue #93

Merged
merged 4 commits into from
Jan 11, 2021
Merged

Conversation

aman-harness
Copy link
Contributor

@aman-harness aman-harness commented Jan 10, 2021

Currently, there is no way to verify if a webhook coming from github is a comment on PR or a comment on an issue. The difference b/w the webhooks is that the latter one has pull_request key in it. We need to forward the info to scm.IssueCommentHook so that the downstram service can understand if which type of comment this is.

scm/driver/github/testdata/issue.json.golden Outdated Show resolved Hide resolved
State string `json:"state"`
Title string `json:"title"`
Body string `json:"body"`
PullRequest pr `json:"pull_request"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attribute will container diff and link only? If you use the pr type it will contain a whole empty struct just filled by the two values.

@bradrydzewski bradrydzewski merged commit e5a5af2 into drone:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants