-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cert pinning from the SDK #537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also remove:
dropbox-sdk-java/core/build.gradle
Lines 85 to 103 in 0f765cb
processResources { task -> filesMatching('**/*.crt') { fcd -> def inputstream = fcd.open() def certDatas = com.dropbox.maven.pem_converter.PemLoader.load( new InputStreamReader(inputstream, "UTF-8") ) inputstream.close() def crtPath = fcd.getPath() def rawPath = crtPath.substring(0, crtPath.length() - 4) + ".raw" def rawFile = new File(task.getDestinationDir(), rawPath); rawFile.getParentFile().mkdirs(); def out = new DataOutputStream(new FileOutputStream(rawFile)) com.dropbox.maven.pem_converter.RawLoader.store(certDatas, out) out.close() fcd.exclude() } } - Used to convert cert to raw format, no longer needed
- https://github.com/dropbox/dropbox-sdk-java/tree/main/gradle/dropbox-pem-converter-plugin/com/dropbox/maven/pem_converter
- used by
processResources
, also no longer needed
- used by
core/src/main/java/com/dropbox/core/http/StandardHttpRequestor.java
Outdated
Show resolved
Hide resolved
@devPalacio Can the crt also be dropped? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wdziemia crt is already deleted :)
No description provided.