-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to dynamically import namespaces from types in the tsd client #235
Conversation
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 51.72% 51.64% -0.08%
==========================================
Files 37 37
Lines 8370 8390 +20
Branches 1786 1789 +3
==========================================
+ Hits 4329 4333 +4
- Misses 3727 3743 +16
Partials 314 314
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good; accepting; consider addressing typo comment.
import_template_string = self.args.import_template_string | ||
import_from_file = self.args.types_file | ||
# /*IMPORT*/ | ||
i_match = re.search("/\\*%s\\*/" % (import_template_string), template) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL this seems super manual, but I see it used in other places. Have we considered using an actual template language library?
stone/backends/tsd_client.py
Outdated
'--types-file', | ||
type=str, | ||
default='', | ||
help=('If using the --import-namespaces flag, this if the file that contains ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: think this comment has a typo
Checklist
General Contributing
Is This a Code Change?
Validation
tox
?