Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting of ApiRoute, guaranteeing stable file output. #260

Merged
merged 2 commits into from
Jan 7, 2022

Conversation

yanks
Copy link
Contributor

@yanks yanks commented Jan 7, 2022

For generations using the JSON-allowlist, the current version does not guarantee that source will be written in the same order. I have addressed this by making sure routes are added in a stable order.

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #260 (00c7d6a) into main (2996b3c) will increase coverage by 0.03%.
The diff coverage is 65.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   51.60%   51.64%   +0.03%     
==========================================
  Files          37       37              
  Lines        8400     8423      +23     
  Branches     1790     1794       +4     
==========================================
+ Hits         4335     4350      +15     
- Misses       3751     3757       +6     
- Partials      314      316       +2     
Flag Coverage Δ
unit 51.64% <65.21%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stone/ir/api.py 81.94% <63.63%> (-2.08%) ⬇️
stone/frontend/ir_generator.py 80.59% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2996b3c...00c7d6a. Read the comment docs.

Copy link
Contributor

@rogebrd rogebrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rogebrd rogebrd merged commit 32b0c0f into dropbox:main Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants