Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid syntax error in .d.ts when the module names end up long #273

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

dgoldstein0
Copy link
Contributor

It is not legal typescript to wrap a declare module "foo/bar" { statement - this is a SyntaxError. as such, we need to self.emit() this statement instead of self.emit_wrapped_text().

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Do I need to? I work for Dropbox.

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

It is not legal typescript to wrap a `declare module "foo/bar" {` statement - this is a SyntaxError.  as such, we need to `self.emit()` this statement instead of `self.emit_wrapped_text()`.
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #273 (73c30a1) into main (9600065) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   52.02%   52.02%           
=======================================
  Files          37       37           
  Lines        8458     8458           
  Branches     1810     1810           
=======================================
  Hits         4400     4400           
  Misses       3741     3741           
  Partials      317      317           
Flag Coverage Δ
unit 52.02% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stone/backends/tsd_types.py 37.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9600065...73c30a1. Read the comment docs.

@rogebrd rogebrd merged commit bdd49bc into main Mar 30, 2022
@rogebrd rogebrd deleted the dgoldstein0-patch-1 branch March 30, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants