Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace deprecated distutils #334

Merged
merged 2 commits into from
May 31, 2024
Merged

fix: Replace deprecated distutils #334

merged 2 commits into from
May 31, 2024

Conversation

Moraxyc
Copy link
Contributor

@Moraxyc Moraxyc commented May 27, 2024

  • fix: Replace deprecated distutils
  • fix: conform PEP 440

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Have you ran pytest?
  • Do the tests pass?

It seems tox test is broken, I got a lot of failures even though using original code.

Pytest:

platform linux -- Python 3.12.3, pytest-8.2.1, pluggy-1.5.0
==== 170 passed, 3 warnings in 10.58s ====

@CLAassistant
Copy link

CLAassistant commented May 27, 2024

CLA assistant check
All committers have signed the CLA.

@Moraxyc
Copy link
Contributor Author

Moraxyc commented May 27, 2024

From Brett Cannon:

Our normal Version class is strict when it comes to Python packaging version support,
so that probably covers what you want. Otherwise you can also use
packaging.utils.canonical_version() if you want even more strict string output.

@Moraxyc
Copy link
Contributor Author

Moraxyc commented May 27, 2024

PEP 440
Version Identification and Dependency Specification

@greg-db
Copy link
Contributor

greg-db commented May 28, 2024

Thanks for putting this together! I'll ask the team to review this.

@KevinRK29 KevinRK29 merged commit f7a29d5 into dropbox:main May 31, 2024
8 of 10 checks passed
@Moraxyc Moraxyc deleted the fix-distutils branch May 31, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants