Add support for Druid Basic Auth to SQLAlchemy #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donbowman
force-pushed
the
add-tls-auth
branch
2 times, most recently
from
b82b3d4
to
32ea4e1
Compare
mistercrunch
reviewed
Feb 1, 2019
mistercrunch
reviewed
Feb 1, 2019
mistercrunch
reviewed
Feb 1, 2019
mistercrunch
requested changes
Feb 1, 2019
|
are there additional changes needed? |
|
before i rebase this again, is there anything else needed? |
This adds support for basic authentication (in the same format as the other sqlalchemy drivers) `druid://USER:PASSWORD@localhost:8082/druid/v2/sql/` Signed-off-by: Don Bowman <[email protected]>
Originally I had this as '' since it means the auth could always be included. Now 'None' is used and no auth header is presented if no user/password is specified.
mistercrunch
approved these changes
Mar 19, 2019
|
Thank you for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for basic authentication (in the same
format as the other sqlalchemy drivers)
druid://USER:PASSWORD@localhost:8082/druid/v2/sql/Signed-off-by: Don Bowman [email protected]