Update to symfony7 #5951
Merged
Update to symfony7 #5951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drush fi not working
| @@ -58,15 +58,15 @@ public function getOption(string $name): mixed | |||
| return false; | |||
| } | |||
|
|
|||
| protected function setTokens(array $tokens) | |||
| protected function setTokens(array $tokens): void | |||
There was a problem hiding this comment.
The path to this file still says v6. Maybe this should be in a v7 folder for clarity.
| @@ -206,6 +206,8 @@ public function loadSymfonyCompatabilityAutoloader(): ClassLoader | |||
| 4 => 'v4', // Drupal 9 | |||
| 5 => 'v4', // Early Drupal 10 (Symfony 5 works with Symfony 4 classes, so we don't keep an extra copy) | |||
| 6 => 'v6', // Drupal 10 | |||
| // @TODO Revisit if needed. | |||
| 7 => 'v6', // Drupal 11 | |||
There was a problem hiding this comment.
Should point to v7, interface is different for v6 vs v7. Could probably remove this mechanism if Drush only supported one major version of Drupal at a time, but it seems useful to support multiple versions.
There was a problem hiding this comment.
I can do this as follow-up work if you want to merge like this to get Symfony 7 into 13.x-dev
|
Almost there. Robo tag is imminent. This will be green once we get wodby/php#194 |
|
@weitzman: Can we merge with disabled (or failing) sqlite tests, and follow up after wodby/php#194 (or Alpine 3.20) is available? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5950
Prereqs