-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add preliminary support for Bun #490
base: master
Are you sure you want to change the base?
Conversation
I tried ❯ bun remove zod
bun remove v1.0.0 (822a00c4)
patch-package 8.0.0
Applying patches...
@remix-run/[email protected] ✔
@remix-run/[email protected] ✔
- zod
1 packages removed [38.00ms] |
64d7436
to
7482db9
Compare
f562909
to
51ee038
Compare
This PR is now ready to merge, with only two caveats as mentioned in #490 (comment). @ds300 Can you please review this PR? :) |
Looking forward to this :) Been using pnpm for a while and been missing patch-package - so having it work with bun will be yummy! Hoping this will work in monorepos as well! |
any news on this? |
Wish I could use patch-package to patch patch-package with this patch 😂 I guess I just need to fork the repo. |
Until this is merged, would you consider publishing this fork on npm @Strengthless? |
LGTM! |
It's happening! Using this method for now oven-sh/bun#2336 (comment) |
@ds300 I understand you probably have lots going on - but having this merged would be a key enabler! 🙏🙂 |
@robertherber I am trying to use this method right now and published it under @miblanchard/[email protected] until this is merged and published. |
Closes #489.
Changelogs:
--use-bun
flag, similar to the current--use-yarn
flag.parseBunLockfile.ts
to convert bun.lockb into yarn v1 lockfiles.getPackageResolution.ts
to handle bun conversions before parsing.detectPackageManager.ts
to detect bun, bun workspaces and multiple lockfiles.Caveats:
Currently awaiting confirmation on how Bun handles postinstalls, for writing up the README about bun setup. (Willbun remove
execute postinstall scripts? If not, bun users should also installpostinstall-postinstall
just like yarn v1 users.)Temporary workaround (while this PR is unmerged):
pnpm patch
/patch-package
oven-sh/bun#2336 (comment),