added 'text-shadow'-property and improved 'text-box' #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2017 04:44
“//“ comments broke my (S)CSS Rendering. “/* */“-comments are safer
added text-shadow attribute with properties in the CSS-Comment
dsandstrom
reviewed
Aug 28, 2017
| @@ -102,7 +102,7 @@ | |||
| 'box-shadow': | |||
| 'prefix': 'bs' | |||
| 'body': """ | |||
| // h-length, v-length, blur, spread, colour | |||
There was a problem hiding this comment.
Don't change the sass comment. I and scss-lint prefer // comments.
| @@ -543,7 +549,7 @@ | |||
| 'box-shadow': | |||
| 'prefix': 'bs' | |||
| 'body': """ | |||
| // h-length, v-length, blur, spread, colour | |||
There was a problem hiding this comment.
Use // for scss, sass, and less. For css, use /* */. This will mean we will have to break out the shadow snippets to a third section.
| 'text-shadow': | ||
| 'prefix': 'ts' | ||
| 'body': """ | ||
| /* h-shadow, v-shadow, blur, colour */ |
There was a problem hiding this comment.
The comment is not necessary. Feel free to leave out if desired.
| 'text-shadow': | ||
| 'prefix': 'ts' | ||
| 'body': """ | ||
| /* h-shadow, v-shadow, blur, colour */ |
There was a problem hiding this comment.
Likewise, use // for scss, /* */ for css.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the 'text-shadow'-property because i think it's an important one and used a lot. Also i changed the comment that was included with the completion of the 'text-box'-property to another comment Form because sometimes CSS breaks with "//"-Commets.