Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare-DscParameterState: Add support for OrderedDictionary type #117

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 23, 2024

Pull Request (PR) description

  • Compare-DscParameterState
    • Add support for DesiredValues (and CurrentValues) to pass a value,
      e.g a hashtable, that includes a property with the type [System.Collections.Specialized.OrderedDictionary]
      or an array of [System.Collections.Specialized.OrderedDictionary] (issue #57).

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cbb838f) 91% compared to head (80779f9) 92%.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #117   +/-   ##
===================================
+ Coverage    91%    92%   +1%     
===================================
  Files        38     38           
  Lines       668    668           
===================================
+ Hits        613    621    +8     
+ Misses       55     47    -8     
Files Coverage Δ
source/Public/Compare-DscParameterState.ps1 85% <100%> (+4%) ⬆️

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit df361a2 into dsccommunity:main Jan 23, 2024
11 checks passed
@johlju johlju deleted the fix/issue-57-part2 branch January 23, 2024 12:29
@johlju johlju removed the needs review The pull request needs a code review. label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrderedDictionary is not supported in Compare-DscParameterState
1 participant