Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-DscResourcePowerShellHelp: Case-insensitive when it looks for the README.md #43

Merged
merged 4 commits into from
Aug 5, 2020

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 1, 2020

Pull Request

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • Integration tests added/updated (where possible).
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from PlagueHO August 1, 2020 15:32
@johlju
Copy link
Member Author

johlju commented Aug 1, 2020

I need to fix unit tests for this change. They were complicated changes to the unit test. :/

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Aug 1, 2020
@johlju johlju added needs review The pull request needs a code review. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Aug 4, 2020
@johlju
Copy link
Member Author

johlju commented Aug 4, 2020

@PlagueHO this one is ready for review now.

Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit 58ca899 into dsccommunity:master Aug 5, 2020
@johlju johlju removed the needs review The pull request needs a code review. label Aug 5, 2020
@johlju johlju deleted the fix/concetual-help branch August 5, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conceptual help cannot be generated if the README.md is using upper-case
2 participants