SqlWindowsFirewall: Avoid Duplication of SQL Server Browser Firewall …

…Rule (#1944) - SqlWindowsFirewall - Fix duplication of SQL Server Browser Firewall Rule when deploying Analysis Services feature (issue #1942).
dsccommunity · May 18, 2023 · 527dcd4 · 527dcd4
1 parent f9bde8a
commit 527dcd4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -27,6 +27,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - `Import-SqlDscPreferredModule`
   - Now when parameter `Force` is passed the command correctly invoke
     `Get-SqlDscPreferredModule` using the parameter `Refresh`.
+- SqlWindowsFirewall
+  - Fix duplication of SQL Server Browser Firewall Rule when deploying
+    Analysis Services feature ([issue #1942](https://github.com/dsccommunity/SqlServerDsc/issues/1942)).
 
 ## [16.3.1] - 2023-05-06
 

diff --git a/source/DSCResources/DSC_SqlWindowsFirewall/DSC_SqlWindowsFirewall.psm1 b/source/DSCResources/DSC_SqlWindowsFirewall/DSC_SqlWindowsFirewall.psm1
@@ -475,6 +475,7 @@ function Set-TargetResource
                     }
 
                     New-NetFirewallRule @browserFirewallRuleParameters
+                    $getTargetResourceResult.BrowserFirewall = $true
                 }
             }
 
@@ -544,6 +545,7 @@ function Set-TargetResource
                     }
 
                     New-NetFirewallRule @browserFirewallRuleParameters
+                    $getTargetResourceResult.BrowserFirewall = $true
                 }
             }