SqlSetup: Missing Configuration Options

[SQLCanuck]

Details of the scenario you tried and the problem that is occurring

SqlSetup is missing the following configuration options for SQL 2016+
SQLSVCINSTANTFILEINIT
SQLTEMPDBFILECOUNT
SQLTEMPDBFILESIZE
SQLTEMPDBFILEGROWTH
SQLTEMPDBLOGFILESIZE
SQLTEMPDBLOGFILEGROWTH

SQLTempDBDir would also need to accept the multiple paths for each possible data file.

SqlSetup is also missing these configuration options for all versions
AGTSVCSTARTUPTYPE
ISSVCSTARTUPTYPE
SQLSVCSTARTUPTYPE

The DSC configuration that is using the resource (as detailed as possible)

Options not available to show in DSC

Version of the operating system and PowerShell the target node is running

Windows Server 2016 Datacenter
PowerShell v5.1

SQL Server edition and version the target node is running

Edition : Enterprise Edition
Version : 13.1.4474.0
Language : 1033

What SQL Server PowerShell modules, and which version, are present on the target node.

SqlServer 21.0.17240

Version of the DSC module you're using, or write 'dev' if you're using current dev branch

SqlServerDsc 11.1.0.0

[johlju]

@SQLCanuck Thanks for reporting this. I think some of these are duplicate to issue #459, but this issue also request additional configuration options not mentioned in #459.

Labeling this as help wanted to someone in the community can run with this one.

[SQLCanuck]

@johlju Thanks. Essentially, looking to have all options available in a SQL configuration file available in SqlSetup as well.

[johlju]

Getting more options in SqlSetup would be great, it would close issues. Someone in the community has to have time to run with it though. 🙂

[banditkd]

I would love to help as I would like to see a couple more options in the setup, ideally everything in the configuration.ini, but small steps. I'll have a look at the guides and see if I can work out how to contribute

[johlju]

@banditkd would be awesome if you could contribute. If you have question or if you need any pointers just tag me here or ping me on Twitter. Happy to help!

[mdaniou]

I could have a look at this. I need some time though.
Any more options that need to be added ?

[johlju]

@mdaniou Take all the time you need. 🙂 You can look on the open issues for SqlSetup to see if there are any more requested options. In the end it would be good to support as many as we can.

[banditkd]

@johlju Sorry for the delay - work got in the way. Finally got round to cloning the repo so now trying to get my head around it and see if i can do anything. I'm no developer but a DBA with an interest in PS and DSC so it might take me a while :)

[johlju]

@banditkd Awesome.

@banditkd and @mdaniou make sure you don't work on adding the same property 🙂

[banditkd]

@johlju no problem. I'll just have a look at the code offline and do a proper fork once i'm up to speed. i'll ping @mdaniou before starting anything in earnest

[mdaniou]

Hi,

I actually starting to work on it.

I would need some help on the options that should be added to the resource.
Could you please have a look at my Excel file here and share your thoughts ?
https://1drv.ms/x/s!AvtxRsEuoRL4ifE-TWb5UGaQ0Zdx1g

Then I think that there should be a project created to handle this so that anyone can pick the options he/she is working on.

I am working on those ones :
/AGTSVCSTARTUPTYPE
/SQLSVCSTARTUPTYPE
/ISSVCStartupType

There are other similar options that I would like to handle at the same time (AS, PB, RS)

Thanks

[johlju]

Regarding a project - happy to create on in this repo, but then each property need to have a separate issue, since issue are the work items on the project board. But if you want to create issues I will happily add them to a project board.

[mdaniou]

Ok, let's confirm all the options and I'll create the issues for each of them, no problem for me :)

[johlju]

@mdaniou I think the Install SQL Server from the Command Prompt is a good source for the available parameters, although it doesn't say which one goes to which version. Tried changing the view query property on the url to '2016' but it seemed that didn't help :)

[mdaniou]

@johlju This is why I have creating the Excel file I referred in my previous message. It contains all the infomation. I only need it to be reviewed eventually.

https://1drv.ms/x/s!AvtxRsEuoRL4ifE-TWb5UGaQ0Zdx1g

[johlju]

@mdaniou The list you got so far seems promising, looked at all the work items that is labeled 'todo', and I have no comments around them what I can think of right now. It looks like you made an awesome job with that list! 😃

[mdaniou]

@johlju Cool thanks !
I'll create the issues from it then.

[johlju]

Looking at the 'Not applicable' I see one that could potentially wanted in the future; INSTANCEID

And if we are gonna support express edition, the properties ENABLERANU and ADDCURRENTUSERASSQLADMIN might be needed? But that can be an entire issue on it's own to support that - might not be enough by adding these properties.

Tag me here when you finished creating issues and I will create the project board.

[mdaniou]

I excluded INSTANCEID and Express on purpose. Actualy I don't really get the point of the INSTANCEID.
However, as it is available, it should be added to at least give the choice.

For Express, I guess that I can create an issue for it as well so that there is at least a discussion about it.

[mdaniou]

@johlju I have created the issues. Could you please add them in a project ?

#1156
#1157
#1158
#1159
#1160
#1161
#1162
#1163
#1164
#1165
#1166
#1167
#1168

[johlju]

@mdaniou Done! Not sure if you can move cards yourself on the board, but if you tag me in an issue and let me know your working on an item I will move it (wish there was some more automation in the projects boards, like label support).

[johlju]

Should we close this issue at this time, since this is being tracked in the other issues?

[mdaniou]

Thanks @johlju !
It seems like I can't move cards, assign to me and update the laebels ... :(

This is annoying ...

[mdaniou]

And yes I would close this issue now.

[johlju]

@mdaniou Yes I know, the GitHub permission model currently is not that granular so giving permission to contributors is not possible. 🙁

I close this issue as this is being tracked in 13 other issues.