-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlSetup: Missing Configuration Feature/Options : Report Service #1163
Comments
@johlju , I've submitted a patch for this, I just need a bit of help to understand patch code coverage (failing) result. |
It’s because the added code is not tested in a unit test. You should add a unit test the passes that parameter and verifies that the argument was passed to the setup process. I think you can see another unit tests in the Set-TargetResource and do the same for this parameter. Also, that parameter should be returned by the Get-TargetResource function (and unit tested also). |
- Changes to SqlServerDsc - Added RSInstallMode parameter (issue #1163).
What is left for this issue is for the SqlSetup resource to support the features RS_SHP : Installs Reporting Services components for SharePoint. |
Details of the scenario you tried and the problem that is occurring
This issue is created to bring some improvements to the SqlSetup DSC Configuration. The idea is to report all the missing options in the resource to be allow the installation of all the features and to use all the options available in the SQL Server installer.
Support for feature to add :
RS_SHP : Installs Reporting Services components for SharePoint.
RS_SHPWFE : Installs Reporting Services Add-In for SharePoint products.
Option to add to the DSC Resource :/RSINSTALLMODE Specifies the Install mode for Reporting Services. Supported Values: SharePointFilesOnlyMode,DefaultNativeMode,FilesOnlyModeWas added in PR #1361.The DSC configuration that is using the resource (as detailed as possible)
SqlSetup
Version of the operating system and PowerShell the target node is running
Windows Server 2012/2012R2/2016
SQL Server edition and version the target node is running
SQL Server 2012/2014/2016
What SQL Server PowerShell modules, and which version, are present on the target node.
Most recent version
Version of the DSC module you're using, or write 'dev' if you're using current dev branch
Most recent version
The text was updated successfully, but these errors were encountered: