Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: SqlSetup: Remove feature flag DetectionSharedFeatures #1290

Closed
johlju opened this issue Feb 25, 2019 · 0 comments · Fixed by #1493
Closed

BREAKING CHANGE: SqlSetup: Remove feature flag DetectionSharedFeatures #1290

johlju opened this issue Feb 25, 2019 · 0 comments · Fixed by #1493
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. Feature preview A feature presently under a feature flag, and will be included in a future breaking change release.

Comments

@johlju
Copy link
Member

johlju commented Feb 25, 2019

Details of the scenario you tried and the problem that is occurring

In PR #1103 the feature flag 'DetectionSharedFeatures' was introduced. This should be made the default in the next major version update (next breaking change release), and the change has been tested for at least one release.

Verbose logs showing the problem

n/a

Suggested solution to the issue

n/a

The DSC configuration that is used to reproduce the issue (as detailed as possible)

n/a

SQL Server edition and version the target node is running

n/a

SQL Server PowerShell modules present on the target node

n/a

The operating system the target node is running

n/a

Version and build of PowerShell the target node is running

n/a

Version of the DSC module that was used ('dev' if using current dev branch)

dev
@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Feb 25, 2019
@johlju johlju added the Feature preview A feature presently under a feature flag, and will be included in a future breaking change release. label Mar 20, 2019
@johlju johlju changed the title SqlSetup: Remove feature flag DetectionSharedFeatures BREAKING CHANGE: SqlSetup: Remove feature flag DetectionSharedFeatures Mar 20, 2019
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Apr 4, 2020
@johlju johlju mentioned this issue Apr 9, 2020
Merged
9 tasks
johlju added a commit that referenced this issue Apr 25, 2020
@johlju
BREAKING CHANGE: SqlSetup: Refactored to speed up testing (#1493)
b05bca4 
- SqlServerDsc
  - The regular expression for `minor-version-bump-message` in the file
    `GitVersion.yml` was changed to only raise minor version when the
    commit message contain the word `add`, `adds`, `minor`, `feature`,
    or `features`.
- SqlSetup
  - BREAKING CHANGE: Logic that was under feature flag `DetectionSharedFeatures`
    was made the default and old logic that was used to detect shared features
    was removed ([issue #1290](#1290)).
    This was implemented because the previous implementation did not work
    fully with SQL Server 2017.
  - Much of the code was refactored into units (functions) to be easier to test.
    Due to the size of the code the unit tests ran for an abnormal long time,
    after this refactoring the unit tests runs much quicker.
  - The property `SqlTempdbLogFileGrowth` and `SqlTempdbFileGrowth` now returns
    the correct values. Previously the value of the growth was wrongly
    divided by 1KB even if the value was in percent. Now the value for growth
    is the sum of the average of MB and average of the percentage.
  - The function `Get-TargetResource` was changed so that the property
    `SQLTempDBDir` will now return the database `tempdb`'s property
    `PrimaryFilePath`.
  - A read only property `IsClustered` was added that can be used to determine
    if the instance is clustered.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. Feature preview A feature presently under a feature flag, and will be included in a future breaking change release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: SqlSetup: Refactored to speed up testing johlju/SqlServerDsc
1 participant
@johlju