Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerDsc: Consequently use parameters ServerName and InstanceName #1392

Closed
johlju opened this issue Jul 14, 2019 · 0 comments · Fixed by #1409
Closed

SqlServerDsc: Consequently use parameters ServerName and InstanceName #1392

johlju opened this issue Jul 14, 2019 · 0 comments · Fixed by #1409
Assignees
@johlju
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Jul 14, 2019 •
edited
Loading

I suggest changing all the helper functions that still uses SQLServer and SQLInstanceName to ServerName and InstanceName respectively. Also, change are references to these helper functions. Any applicable aliases could also be removed at that time.

For any resource still using the parameters SQLServer and SQLInstanceName a issues should be submitted.
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Jul 14, 2019
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jul 18, 2019
@johlju
Parameters now match that of Connect-SQL (issue dsccommunity#1392)
9739a77
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jul 18, 2019
@johlju johlju mentioned this issue Jul 18, 2019
Merged
9 tasks
@johlju johlju self-assigned this Jul 18, 2019
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jul 22, 2019
@johlju
Parameters now match that of Connect-SQL (issue dsccommunity#1392)
416462e
johlju added a commit that referenced this issue Jul 22, 2019
@johlju
SqlServerDsc: Consequently use parameters ServerName and InstanceName (…
f9e2939 
…#1409)

- Changes to SqlServerDsc
  - Changes to helper function Invoke-Query
    - Parameters now match that of Connect-SQL (issue #1392).
  - Changes to helper function Connect-SQLAnalysis
    - Parameters now match that of Connect-SQL (issue #1392).
  - Changes to helper function Restart-SqlService
    - Parameters now match that of Connect-SQL (issue #1392).
  - Changes to helper function Restart-ReportingServicesService
    - Parameters now match that of Connect-SQL (issue #1392).
  - Changes to helper function Split-FullSqlInstanceName
    - Parameters and function name changed to use correct casing.
  - Changes to helper function Get-SqlInstanceMajorVersion
    - Parameters now match that of Connect-SQL (issue #1392).
  - Changes to helper function Test-LoginEffectivePermissions
    - Parameters now match that of Connect-SQL (issue #1392).
  - Changes to helper function Test-AvailabilityReplicaSeedingModeAutomatic
    - Parameters now match that of Connect-SQL (issue #1392).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerDsc: Consequently use parameters ServerName and InstanceName johlju/SqlServerDsc
1 participant
@johlju