Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerDsc.Common: Invoke-Query silently runs queries even with Verbose #1404

Closed
johlju opened this issue Jul 16, 2019 · 0 comments · Fixed by #1407
Closed

SqlServerDsc.Common: Invoke-Query silently runs queries even with Verbose #1404

johlju opened this issue Jul 16, 2019 · 0 comments · Fixed by #1407
Assignees
@johlju
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Jul 16, 2019

I suggest we add verbose messages to Invoke-Query so that when called with -Verbose it outputs the query run, and if it will return results or not.
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Jul 16, 2019
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jul 18, 2019
@johlju
Changes to helper function Invoke-Query
c587e4d 
- Now it will output verbose messages of the query that is run, so it
  not as quiet of what it is doing when a user asks for verbose output (issue dsccommunity#1404).
- It is possible to redact text in the verbose output by providing
  strings in the new parameter `RedactText`.
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jul 18, 2019
@johlju johlju self-assigned this Jul 18, 2019
@johlju johlju mentioned this issue Jul 18, 2019
Merged
9 tasks
johlju added a commit that referenced this issue Jul 22, 2019
@johlju
SqlServerDsc: Changes to Invoke-Query (#1407)
adcf2bb 
- Changes to helper function Invoke-Query
  - Now it will output verbose messages of the query that is run, so it
    not as quiet of what it is doing when a user asks for verbose output (issue #1404).
  - It is possible to redact text in the verbose output by providing
    strings in the new parameter `RedactText`.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerDsc: Changes to Invoke-Query johlju/SqlServerDsc
1 participant
@johlju