Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: Link to non-existent page on dev branch #1508

Closed
Rob-S opened this issue Apr 21, 2020 · 1 comment · Fixed by #1507
Closed

README.md: Link to non-existent page on dev branch #1508

Rob-S opened this issue Apr 21, 2020 · 1 comment · Fixed by #1507
Labels
documentation The issue is related to documentation only.

Comments

@Rob-S
Copy link
Contributor

Rob-S commented Apr 21, 2020

In README.md, the "Contributing to SqlServerDsc" link goes to a non-existent page on the dev branch.
@Rob-S
Copy link
Contributor Author

Rob-S commented Apr 21, 2020

Fixed in PR #1484

@johlju johlju added documentation The issue is related to documentation only. in progress The issue is being actively worked on by someone. labels Apr 22, 2020
@Rob-S Rob-S mentioned this issue Apr 22, 2020
Merged
2 tasks
johlju pushed a commit that referenced this issue Apr 25, 2020
@Rob-S
BREAKING CHANGE: SqlDatabaseOwner/Permission/Role: Update parameter D…
8ec8095 
…atabase to DatabaseName (#1507)

- BREAKING CHANGE: Database changed to DatabaseName for consistency with other modules.
  ([issue #1484](#1484)).
  - SqlDatabaseOwner
  - SqlDatabasePermission
  - SqlDatabaseRole
- README.md
  - Changed to point to CONTRIBUTING.md on master branch to avoid "404 Page not found" (issue #1508).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation The issue is related to documentation only.
Projects
None yet
Milestone
No milestone
2 participants
@Rob-S @johlju