Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlSetup: Should not skip cluster validation tests #335

Closed
nabrond opened this issue Jan 23, 2017 · 1 comment · Fixed by #1554
Closed

SqlSetup: Should not skip cluster validation tests #335

nabrond opened this issue Jan 23, 2017 · 1 comment · Fixed by #1554
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.

Comments

@nabrond
Copy link
Contributor

nabrond commented Jan 23, 2017

Details of the scenario you try and problem that is occurring:
When installing a clustered SQL Server instance, the undocumented parameter /SkipRules='Cluster_VerifyForErrors' is automatically added to the setup arguments. This can introduce supportability issues when contacting Microsoft for support. See this article for more information. This option should be converted to a parameter to support all use cases.

The DSC configuration that is using the resource (as detailed as possible):
Any configuration which specifies 'InstallFailoverCluster' or 'CompleteFailoverCluster' for the parameter 'Action'.

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
Windows Server 2008R2+

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
dev
@nabrond nabrond mentioned this issue Jan 23, 2017
Merged
5 tasks
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jan 23, 2017
@johlju johlju mentioned this issue Mar 13, 2017
Closed
@johlju johlju changed the title xSQLServerSetup: Should not skip cluster validation tests. SqlSetup: Should not skip cluster validation tests. Dec 22, 2017
@johlju johlju changed the title SqlSetup: Should not skip cluster validation tests. SqlSetup: Should not skip cluster validation tests May 6, 2020
@johlju johlju added the breaking change When used on an issue, the issue has been determined to be a breaking change. label May 6, 2020
@johlju
Copy link
Member

johlju commented May 7, 2020 •
edited
Loading

We should add a parameter SkipRule.

We should allow it to pass several rules:
https://dba.stackexchange.com/questions/115377/skip-multiple-rules-during-sql-server-installation

Since these are undocumented this is blog and has a reference; https://deep.data.blog/2014/04/02/sql-2012-setup-rules-the-missing-reference/

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels May 22, 2020
@johlju johlju mentioned this issue May 22, 2020
Merged
9 tasks
johlju added a commit that referenced this issue May 25, 2020
@johlju
BREAKING CHANGE: SqlSetup: Remove default skip cluster validation (#1554
c8a7076 
)

- SqlSetup
  - BREAKING CHANGE: When installing a failover cluster the cluster
    validation is no longer skipped by default. To skip cluster validation
    the configuration must opt-in by specifying the following
    `SkipRule = 'Cluster_VerifyForErrors'` (issue #335).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: SqlSetup: Remove default skip cluster validation johlju/SqlServerDsc
2 participants
@nabrond @johlju