Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlWindowsFirewall: Localization should change to align with HQRM modules #614

Closed
johlju opened this issue Jun 6, 2017 · 0 comments · Fixed by #1336
Closed

SqlWindowsFirewall: Localization should change to align with HQRM modules #614

johlju opened this issue Jun 6, 2017 · 0 comments · Fixed by #1336
Assignees
@johlju
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jun 6, 2017

Details of the scenario you tried and the problem that is occurring:
Resource should use the same method of localization as HQRM modules (PSDscResource). More information in PR #205.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jun 6, 2017
@johlju johlju changed the title xSQLServerFirewall: Localization should change to align with HQRM modules SqlWindowsFirewall: Localization should change to align with HQRM modules Dec 24, 2017
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Apr 25, 2019
johlju added a commit to johlju/SqlServerDsc that referenced this issue Apr 25, 2019
@johlju
- Changes to SqlWindowsFirewall
f6ef7c1 
  - Added en-US localization (issue dsccommunity#614).
@johlju johlju mentioned this issue Apr 25, 2019
Merged
9 tasks
johlju added a commit to johlju/SqlServerDsc that referenced this issue Apr 26, 2019
@johlju
- Changes to SqlWindowsFirewall
10df1b4 
  - Added en-US localization (issue dsccommunity#614).
johlju added a commit that referenced this issue Apr 26, 2019
@johlju
SqlWindowsFirewall: Added localization (#1336)
874c8aa 
- Changes to SqlSetup
  - Made the error message more descriptive when the Set-TargetResource
    function calls the Test-TargetResource function to verify the desired
    state.
- Changes to SqlWindowsFirewall
  - Added en-US localization (issue #614).
- Changes to SqlRS
  - Fixed one of the error handling to use localization, and made the
    error message more descriptive when the Set-TargetResource function
    calls the Test-TargetResource function to verify the desired
    state.
@kwirkykat kwirkykat removed the in progress The issue is being actively worked on by someone. label Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlWindowsFirewall: Added localization johlju/SqlServerDsc
2 participants
@kwirkykat @johlju