Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerLogin: Localization should change to align with HQRM modules #615

Closed
johlju opened this issue Jun 6, 2017 · 0 comments · Fixed by #1333
Closed

SqlServerLogin: Localization should change to align with HQRM modules #615

johlju opened this issue Jun 6, 2017 · 0 comments · Fixed by #1333
Assignees
@johlju
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jun 6, 2017

Details of the scenario you tried and the problem that is occurring:
Resource should use the same method of localization as HQRM modules (PSDscResource). More information in PR #205.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jun 6, 2017
@johlju johlju changed the title xSQLServerLogin: Localization should change to align with HQRM modules SqlServerLogin: Localization should change to align with HQRM modules Dec 24, 2017
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Apr 24, 2019
johlju added a commit to johlju/SqlServerDsc that referenced this issue Apr 24, 2019
@johlju
Changes to SqlServerLogin
68f3f5f 
- Added en-US localization (issue dsccommunity#615).
- Added unit tests to improved code coverage.
@johlju johlju mentioned this issue Apr 24, 2019
Merged
9 tasks
johlju added a commit to johlju/SqlServerDsc that referenced this issue Apr 25, 2019
@johlju
Changes to SqlServerLogin
556142b 
- Added en-US localization (issue dsccommunity#615).
- Added unit tests to improved code coverage.
johlju added a commit to johlju/SqlServerDsc that referenced this issue Apr 26, 2019
@johlju
Changes to SqlServerLogin
3d0c674 
- Added en-US localization (issue dsccommunity#615).
- Added unit tests to improved code coverage.
johlju added a commit that referenced this issue Apr 26, 2019
@johlju
SqlServerLogin: Added localization (#1333)
a15089f 
- Changes to SqlServerLogin
  - Added en-US localization (issue #615).
  - Added unit tests to improved code coverage.
@kwirkykat kwirkykat removed the in progress The issue is being actively worked on by someone. label Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerLogin: Added localization johlju/SqlServerDsc
2 participants
@kwirkykat @johlju