Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xSQLServer: Opt-in for module files common tests #702

Closed
johlju opened this issue Jul 20, 2017 · 1 comment
Closed

xSQLServer: Opt-in for module files common tests #702

johlju opened this issue Jul 20, 2017 · 1 comment
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jul 20, 2017

Details of the scenario you tried and the problem that is occurring:
We should opt-in for the module files common tests so that we can easier enforce the style guideline.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. labels Jul 20, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jul 20, 2017
@johlju
Changes to xSQLServer
0dd7487 
- Opt-in for module files common tests (issue dsccommunity#702).
  - Removed Byte Order Mark (BOM) from the files;
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jul 20, 2017
@johlju
Changes to xSQLServer
d9f5442 
- Opt-in for module files common tests (issue dsccommunity#702).
  - Removed Byte Order Mark (BOM) from the files;
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jul 20, 2017
@johlju
Changes to xSQLServer
8acf572 
- Opt-in for module files common tests (issue dsccommunity#702).
  - Removed Byte Order Mark (BOM) from the files; CommonResourceHelper.psm1, MSFT_xSQLServerAvailabilityGroupListener.psm1, MSFT_xSQLServerConfiguration.psm1, MSFT_xSQLServerEndpointPermission.psm1, MSFT_xSQLServerEndpointState.psm1, MSFT_xSQLServerNetwork.psm1, MSFT_xSQLServerPermission.psm1, MSFT_xSQLServerReplication.psm1, MSFT_xSQLServerScript.psm1, SQLPSStub.psm1, SQLServerStub.psm1.
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jul 20, 2017
@johlju
Changes to xSQLServer
6fc2842 
- Opt-in for module files common tests (issue dsccommunity#702).
  - Removed Byte Order Mark (BOM) from the files; CommonResourceHelper.psm1, MSFT_xSQLServerAvailabilityGroupListener.psm1, MSFT_xSQLServerConfiguration.psm1, MSFT_xSQLServerEndpointPermission.psm1, MSFT_xSQLServerEndpointState.psm1, MSFT_xSQLServerNetwork.psm1, MSFT_xSQLServerPermission.psm1, MSFT_xSQLServerReplication.psm1, MSFT_xSQLServerScript.psm1, SQLPSStub.psm1, SQLServerStub.psm1.
@johlju johlju mentioned this issue Jul 20, 2017
Merged
5 tasks
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jul 21, 2017
@johlju
Changes to xSQLServer
20c6b8f 
- Opt-in for module files common tests (issue dsccommunity#702).
  - Removed Byte Order Mark (BOM) from the files; CommonResourceHelper.psm1, MSFT_xSQLServerAvailabilityGroupListener.psm1, MSFT_xSQLServerConfiguration.psm1, MSFT_xSQLServerEndpointPermission.psm1, MSFT_xSQLServerEndpointState.psm1, MSFT_xSQLServerNetwork.psm1, MSFT_xSQLServerPermission.psm1, MSFT_xSQLServerReplication.psm1, MSFT_xSQLServerScript.psm1, SQLPSStub.psm1, SQLServerStub.psm1.
johlju added a commit that referenced this issue Jul 21, 2017
@johlju
xSQLServer: Opt-in for module files common tests (#704)
035a5ad 
- Changes to xSQLServer
  - Opt-in for module files common tests (issue #702).
    - Removed Byte Order Mark (BOM) from the files; CommonResourceHelper.psm1,
      MSFT\_xSQLServerAvailabilityGroupListener.psm1, MSFT\_xSQLServerConfiguration.psm1,
      MSFT\_xSQLServerEndpointPermission.psm1, MSFT\_xSQLServerEndpointState.psm1,
      MSFT\_xSQLServerNetwork.psm1, MSFT\_xSQLServerPermission.psm1,
      MSFT\_xSQLServerReplication.psm1, MSFT\_xSQLServerScript.psm1,
      SQLPSStub.psm1, SQLServerStub.psm1.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jul 21, 2017
@johlju
Copy link
Member Author

johlju commented Jul 22, 2017

This was merged in PR #704.

@johlju johlju closed this as completed Jul 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johlju